Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ign ➡️ gz] Update VCS directory for Windows CI #738

Merged
merged 2 commits into from
Aug 3, 2022
Merged

[ign ➡️ gz] Update VCS directory for Windows CI #738

merged 2 commits into from
Aug 3, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina requested a review from j-rivero as a code owner June 7, 2022 23:02
@chapulina chapulina mentioned this pull request Jun 7, 2022
Closed
@chapulina chapulina marked this pull request as draft June 7, 2022 23:46
methylDragon
methylDragon approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 24, 2022
@j-rivero j-rivero marked this pull request as ready for review August 2, 2022 18:24
@j-rivero
Copy link
Contributor

j-rivero commented Aug 2, 2022

First test to make this work (together with gazebo-tooling/gazebodistro#112) failed https://build.osrfoundation.org/job/_test_ign_utils-ign-1-win. There is a checkout directory configuration in DSL that needs patching, I'll look into it

This was referenced Aug 2, 2022
Closed
Merged
@j-rivero
Copy link
Contributor

j-rivero commented Aug 3, 2022

Together with gazebo-tooling/gazebodistro#117 seems to work file.

@j-rivero j-rivero merged commit 43243db into master Aug 3, 2022
@j-rivero j-rivero deleted the chapulina/win_gz_vcs branch August 3, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
ign to gz Renaming Ignition to Gazebo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @j-rivero @methylDragon