-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ign -> gz: rename files, change directories, create symlinks #117
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, so just to summarize the breaking changes as I understand them:
Broken:
- Direct links to specific files, like https://raw.githubusercontent.com/gazebo-tooling/gazebodistro/master/ign-common5.yaml (i.e. https://raw.githubusercontent.com/gazebo-tooling/gazebodistro/jrivero/gz_migration/ign-common5.yaml)
- Logic that relies on the checkout directories (i.e.
cd ws/src/ign-gazebo
)
Not broken:
- Accessing specific files in UNIX after cloning
gazebodistro
, i.e.git clone ...gazebodistro; cat ign-gazebo6.yaml
I took a quick look at our docs and tooling, and I believe nothing will be affected by this besides Windows CI, which has a PR open to fix it. Most places are using the collection-X.yaml
files and I don't think they're using the paths to each repo.
correct as far as I can tell.
That is also my impression. Let's merge both PRs and fix anything that appear afterwards if any. |
Ok, we have our first failure, Windows CI for
https://build.osrfoundation.org/job/ign_gazebo-pr-win/4853/console |
Umm I thought I have changed the DSL code yesterday playing with the PRs in release-tools. Somehow the changes were not done, fixing it now. |
The PR replaces #109 and #112 and did three different changes:
Tested together with gazebo-tooling/release-tools#738
I was using the following commands:
Caveats: