Skip to content

Commit

Permalink
fix: Revert changes (#399)
Browse files Browse the repository at this point in the history
* Revert "feat: Add middleware to log all post requests (#397)"

This reverts commit 71f918a.

* Revert "feat: Added loggers in sdk and changed version (#398)"

This reverts commit f1a84c8.
  • Loading branch information
Ashutosh619-sudo authored Oct 14, 2024
1 parent f1a84c8 commit fb5ff1a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 28 deletions.
20 changes: 0 additions & 20 deletions fyle_xero_api/logging_middleware.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import json
import logging
import traceback

Expand Down Expand Up @@ -26,22 +25,3 @@ def process_exception(self, request, exception):
logger.error(str(message).replace("\n", ""))

return HttpResponse("Error processing the request.", status=500)


class LogPostRequestMiddleware:
def __init__(self, get_response):
self.get_response = get_response

def __call__(self, request):
if request.method in ['POST', 'PUT']:
try:
body_unicode = request.body.decode('utf-8')
request_body = json.loads(body_unicode)
logger.info("POST request to %s: %s", request.path, request_body)
except (json.JSONDecodeError, UnicodeDecodeError):
logger.warning("Failed to decode POST request body for %s", request.path)
except Exception as e:
logger.info('Something went wrong when logging post call - %s', e)

response = self.get_response(request)
return response
6 changes: 0 additions & 6 deletions fyle_xero_api/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
MIDDLEWARE = [
"request_logging.middleware.LoggingMiddleware",
"fyle_xero_api.logging_middleware.ErrorHandlerMiddleware",
"fyle_xero_api.logging_middleware.LogPostRequestMiddleware",
"corsheaders.middleware.CorsMiddleware",
"django.middleware.common.CommonMiddleware",
"corsheaders.middleware.CorsPostCsrfMiddleware",
Expand Down Expand Up @@ -201,11 +200,6 @@
"handlers": ["debug_logs"],
"propagate": True
},
'xerosdk.apis.api_base': {
'handlers': ['console'],
'level': 'INFO',
'propagate': True
},
},
}

Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ djangorestframework==3.11.2
django-sendgrid-v5==1.2.0
enum34==1.1.10
future==0.18.2
fyle==0.37.2
fyle==0.37.0
fyle-accounting-mappings==1.34.8
fyle-integrations-platform-connector==1.38.4
fyle-rest-auth==1.7.2
Expand All @@ -41,7 +41,7 @@ Unidecode==1.1.2
urllib3==1.26.11
wcwidth==0.1.8
wrapt==1.12.1
xerosdk==0.14.2
xerosdk==0.14.1
pytest==7.1.2
pytest-cov==3.0.0
pytest-django==4.5.2
Expand Down

0 comments on commit fb5ff1a

Please sign in to comment.