[HapticFeedback] Implement vibrate()

[pwasowski2]

[Before] HapticFeedback.vibrate() was not implemented

[After] The code below will cause a short vibration:

  HapticFeedback.vibrate();

Signed-off-by: Pawel Wasowski [email protected]

HapticFeedback.vibrate() was one of the features to implement on this list #53 (comment)

Before building with this change, be sure to use tizen_tools with this commit applied: https://github.com/flutter-tizen/tizen_tools/pull/10

The change will only work on devices that support it. I have tested it on a Samsung Z3 (aka TM1) smartphone with Tizen 6.5.

[pwasowski2]

As this is my first change in flutter-tizen/engine, I'm not sure about the design of my patch. I've tried to follow the contributor's guidelines from the original flutter/engine repo, but I'd like to know your opinion about some things :)

1. I've put FeedbackManager class implementation in platform_channel.cc. Honestly, I consider it to be a little bit of a code smell, and would rather put this class in separate files (standard .h and .cc combination for declaration and definitions), but I didn't know where to put these files in the repo's source tree. Do you think, I can put them (i.e. feedback_manager.h and feedback_manager.cc) directly in src/flutter/shell/platform/tizen/channels?
2. From what I've seen, Flutter has no strict rules regarding formulation of error messages. I've tried to make my messages meaningful - have I got it right?

[swift-kim]

I've put FeedbackManager class implementation in platform_channel.cc. Honestly, I consider it to be a little bit of a code smell,

I personally don't mind this.

Do you think, I can put them (i.e. feedback_manager.h and feedback_manager.cc) directly in src/flutter/shell/platform/tizen/channels?

Yes, you can. You can also refer to other platform implementations and find the best way you think.

From what I've seen, Flutter has no strict rules regarding formulation of error messages. I've tried to make my messages meaningful - have I got it right?

Printing meaningful error messages is always a good thing and I think you're doing right. You should use FT_LOGE rather than FT_LOGD to print your error to the tool's log console. The flutter-tizen tool only prints log messages with the log level INFO or above. There's no other rule for formatting log messages AFAIK.

[pkosko]

LGTM

[bbrto21]

LGTM