Resolve build reproducibility issues #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]>
This was referenced Sep 9, 2022
sparr
reviewed
Sep 9, 2022
| @@ -22,7 +22,21 @@ jobs: | |||
| go-version: ${{ matrix.go }} | |||
|
|
|||
| - name: Check out code into the Go module directory | |||
| uses: actions/checkout@v2 | |||
| uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
Is it worth investigating how complex it would be to make a checkout action that gets exactly what we need rather than always this static number that will usually be more?
There was a problem hiding this comment.
It's definitely outside my effective scope. Mainly thinking checkout is written in Typescript and I may spend more time spinning up on that than I would prefer.
ginglis13
approved these changes
Sep 9, 2022
kzys
approved these changes
Sep 9, 2022
vvejell1
pushed a commit
to vvejell1/firectl
that referenced
this pull request
Nov 8, 2022
Resolve build reproducibility issues Signed-off-by: Debian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change is meant to address the build reproducibility issues by pinning the lint dependencies.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.