Remove io/ioutil package dependency #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we are having the same issue here re pinned dependencies, specifically ltag again as was the case addressed by this PR on the firecracker-go-sdk firecracker-microvm/firecracker-go-sdk#445 |
This was referenced Sep 9, 2022
sbuckfelder
approved these changes
Sep 9, 2022
sparr
reviewed
Sep 9, 2022
ginglis13
approved these changes
Sep 9, 2022
Package io/ioutil deprecated since Go 1.16 Reference: https://go.dev/doc/go1.16#ioutil Signed-off-by: Austin Vazquez <[email protected]>
Kern--
reviewed
Sep 9, 2022
| @@ -244,7 +243,7 @@ func (opts *options) handleFifos() (io.Writer, error) { | |||
| } | |||
|
|
|||
| if generateFifoFilename || generateMetricFifoFilename { | |||
| dir, err := ioutil.TempDir(os.TempDir(), "fcfifo") | |||
| dir, err := os.MkdirTemp("", "fcfifo") | |||
There was a problem hiding this comment.
These replacements were introduced in go 1.16 and we claim to be able to build as far back as 1.14.
I think buildkite is currently on 1.15 so we would need to update that before merging this and remove go 1.14 and 1.15 from the GHA build matrix. Since firectl is a binary I think we can be a bit more aggressive in updating the go versions than the go sdk.
There was a problem hiding this comment.
Opened #95 to capture thoughts on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Package io/ioutil deprecated since Go 1.16
Reference: https://go.dev/doc/go1.16#ioutil
Requires #93
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Signed-off-by: Austin Vazquez [email protected]