-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add faraday adapter customization #122
Open
apneadiving
wants to merge
1
commit into
facebook:main
Choose a base branch
from
apneadiving:add-custom-adapter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# Copyright (c) 2017-present, Facebook, Inc. All rights reserved. | ||
# | ||
# You are hereby granted a non-exclusive, worldwide, royalty-free license to use, | ||
# copy, modify, and distribute this software in source code or binary form for use | ||
# in connection with the web services and APIs provided by Facebook. | ||
# | ||
# As with any software that integrates with the Facebook platform, your use of | ||
# this software is subject to the Facebook Platform Policy | ||
# [http://developers.facebook.com/policy/]. This copyright notice shall be | ||
# included in all copies or substantial portions of the software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS | ||
# FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR | ||
# COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER | ||
# IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN | ||
# CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
||
|
||
RSpec.describe FacebookAds::Config do | ||
it 'provides with default config' do | ||
expect(subject).to have_attributes( | ||
server_host: FacebookAds::DEFAULT_HOST, | ||
api_version: FacebookAds::DEFAULT_API_VERSION, | ||
access_token: ENV['FB_ACCESS_TOKEN'], | ||
app_secret: ENV['FB_APP_SECRET'], | ||
crash_logging_enabled: true, | ||
log_api_bodies: false, | ||
faraday_adapter: Faraday.default_adapter | ||
) | ||
end | ||
|
||
context 'custom config' do | ||
let(:fake_adapter) { double(:fake_adapter) } | ||
|
||
it 'saves custom values' do | ||
subject.faraday_adapter = fake_adapter | ||
|
||
expect(subject.faraday_adapter).to eq fake_adapter | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it does require faraday which is now needed in config for the default value