Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add faraday adapter customization #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apneadiving
Copy link

I needed to have a custom adapter (for easy retry purposes basically).
I think it could help other people.

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests.
  3. If you've changed APIs, update the documentation.
    Not the case
  4. Ensure the test suite passes.
  5. Make sure your code lints.
    ❌ the code has 13334 offenses detected without my changes
  6. If you haven't already, complete the Contributor License Agreement ("CLA").

@@ -45,9 +45,9 @@ def configure

require 'facebook_ads/ruby2patch'

require 'facebook_ads/session'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it does require faraday which is now needed in config for the default value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants