Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show warning when undefined function found #245

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Jul 31, 2017

with this PR we can find unix:uleep case (start-jsk/jsk_apc#2241 (review))
cc: start-jsk/jsk_apc#2497

$ (progn (load "~/catkin_ws/ws_jsk_apc/src/euslisp/euslisp/lisp/comp/trans.l")(comp::compile-file "hoge.l"))
compiling file: hoge.l
; bb is assumed to be global
; bb is assumed to be global
; unix::uleep is assumed to be undefined function
gcc -g -c -Dx86_64 -DLinux -Wimplicit -falign-functions=8 -DGCC3  -DGCC  -DTHREADED -DPTHREAD -fpic  -I/opt/ros/indigo/share/euslisp/jskeus/eus/include -O2 hoge.c; ld -shared -build-id -o hoge.so hoge.o
$ cat hoge.l

(defun fuga nil
  (setq bb 10)
  (unix:usleep 1)
  )

(defun hoge nil
  (setq bb 10)
  (unix::uleep 1) ;;this fails in compie
  )

@k-okada k-okada changed the title lispio.c:READLINE cb[i-1] && i>=1 is not correct, use i>=1 && cb[i-1] "show warning when undefined function found Jul 31, 2017
@k-okada k-okada changed the title "show warning when undefined function found show warning when undefined function found Jul 31, 2017
Copy link
Member

@YoheiKakiuchi YoheiKakiuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-okada k-okada merged commit 08fa27d into euslisp:master Sep 8, 2017
@k-okada k-okada deleted the undefined_function branch September 8, 2017 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants