-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: examples to connect multiple Nutanix sites and migrate VMs betwe… #71
Conversation
PR ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging to ease review and testing ahead of a release
I can't merge with the current linting errors. Please correct them (I've opened a PR here: codinja1188#1) You will also need to rebase the branch to get the changes from #82 that this PR depends on to successfully lint. It may help to install pre-commit and trivy then run |
examples/nutanix-clusters/main.tf
Outdated
|
||
module "nutanix_cluster1" { | ||
source = "equinix-labs/metal-nutanix-cluster/equinix" | ||
version = "0.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "0.3.1" | |
version = "0.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release version is 0.4.0, missing tage for v0.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codinja1188 The 0.4.0 release was pushed with the wrong tag. I went ahead and added the v0.4.0 tag and updated the existing release to point to the correct tag.
We're getting flakes related to hashicorp providers. In a previous CI build it was
Reran all jobs and got a different set of errors:
|
All checks are passed |
Part of #68