Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: examples to connect multiple Nutanix sites and migrate VMs betwe… #71

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

codinja1188
Copy link
Contributor

@codinja1188 codinja1188 commented May 29, 2024

Part of #68

@displague displague changed the title Fix: examples to connect multiple Nutanix sites and migrate VMs betwe… feat: examples to connect multiple Nutanix sites and migrate VMs betwe… Jun 3, 2024
examples/nutanix-clusters/main.tf Outdated Show resolved Hide resolved
examples/nutanix-clusters/main.tf Outdated Show resolved Hide resolved
examples/nutanix-clusters/outputs.tf Outdated Show resolved Hide resolved
examples/nutanix-clusters/terraform.tfvars Outdated Show resolved Hide resolved
@codinja1188 codinja1188 marked this pull request as ready for review July 5, 2024 17:04
@codinja1188
Copy link
Contributor Author

@displague ,

PR ready for review

displague
displague previously approved these changes Jul 13, 2024
Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to ease review and testing ahead of a release

@displague
Copy link
Member

I can't merge with the current linting errors. Please correct them (I've opened a PR here: codinja1188#1)

You will also need to rebase the branch to get the changes from #82 that this PR depends on to successfully lint.

It may help to install pre-commit and trivy then run pre-commit install, and pre-commit run --all-files.


module "nutanix_cluster1" {
source = "equinix-labs/metal-nutanix-cluster/equinix"
version = "0.3.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.3.1"
version = "0.4.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@displague,

Release version is 0.4.0, missing tage for v0.4.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codinja1188 The 0.4.0 release was pushed with the wrong tag. I went ahead and added the v0.4.0 tag and updated the existing release to point to the correct tag.

@displague
Copy link
Member

displague commented Jul 17, 2024

We're getting flakes related to hashicorp providers. In a previous CI build it was local and now it is random.

Terraform validate......................................................................Failed
- hook id: terraform_validate
- exit code: 1
Command 'terraform init' successfully done: modules/ssh
Validation failed: modules/ssh
╷
│ Error: registry.terraform.io/hashicorp/random: the cached package for registry.terraform.io/hashicorp/random 3.6.2 (in .terraform/providers) does not match any of the checksums recorded in the dependency lock file
│ 
│ 
╵
Error: Terraform exited with code 1.

Reran all jobs and got a different set of errors:

Command 'terraform init' successfully done: modules/ssh
Validation failed: modules/ssh
╷
│ Error: missing or corrupted provider plugins:
│   - registry.terraform.io/equinix/equinix: the cached package for registry.terraform.io/equinix/equinix 2.2.0 (in .terraform/providers) does not match any of the checksums recorded in the dependency lock file
│   - registry.terraform.io/hashicorp/local: the cached package for registry.terraform.io/hashicorp/local 2.5.1 (in .terraform/providers) does not match any of the checksums recorded in the dependency lock file
│ 
│ 
╵
Error: Terraform exited with code 1.

@codinja1188
Copy link
Contributor Author

@displague ,

All checks are passed

@displague displague merged commit 8c7804d into equinix-labs:main Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants