Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates from migration example qa/review #89

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Conversation

displague
Copy link
Member

@displague displague commented Jul 18, 2024

WIP to review the migration example

Follow up to #71

Part of #68
Fixes #74

@displague displague force-pushed the nutanix-migration-review branch 3 times, most recently from e57e33d to d491b16 Compare July 19, 2024 20:57
-L 19440:$nutanix_cluster1_cvim_ip_address:9440 \
-i $nutanix_cluster1_ssh_private_key \
-J root@$nutanix_cluster1_bastion_public_ip \
admin@$nutanix_cluster1_cvim_ip_address
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the Nutanix clusters see the bastion, .2, as their gateway, adding this route to the bastion should work, but it would add an extra hop.

We could have 0 hops with https://github.com/equinix-labs/terraform-equinix-metal-nutanix-cluster/pull/89/files#r1684973671

I'm just calling this out. Not expecting a change in the root module at this time.

Copy link
Member Author

@displague displague Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was testing, CVIM was not available. If it was up, I imagine we could make this a one-liner, with \ at the end of the admin line and sudo ip route as the command run directly from the single ssh command line.

We should explain that we are using ssh -J to use the bastion as a Jump Host.

@displague
Copy link
Member Author

displague commented Jul 19, 2024

CI is acting really wonky. It appears to be pulling from old revisions that are neither the target nor HEAD of this branch.

diff --git a/examples/nutanix-clusters/README.md b/examples/nutanix-clusters/README.md
index ebca21e..08da97c 100644
--- a/examples/nutanix-clusters/README.md
+++ b/examples/nutanix-clusters/README.md
@@ -311,4 +311,4 @@ This example demonstrates how to create two Nutanix clusters and set up a protec
 | <a name="output_nutanix_cluster2_ssh_forward_command"></a> [nutanix\_cluster2\_ssh\_forward\_command](#output\_nutanix\_cluster2\_ssh\_forward\_command) | SSH port forward command to use to connect to the Prism GUI |
 | <a name="output_nutanix_cluster2_ssh_private_key"></a> [nutanix\_cluster2\_ssh\_private\_key](#output\_nutanix\_cluster2\_ssh\_private\_key) | The SSH keypair's private key for cluster1 |
 | <a name="output_nutanix_cluster2_virtual_ip_address"></a> [nutanix\_cluster2\_virtual\_ip\_address](#output\_nutanix\_cluster2\_virtual\_ip\_address) | Reserved IP for cluster virtal IP |
-<!-- END_TF_DOCS -->
\ No newline at end of file
+<!-- END_TF_DOCS -->

I didn't have that line, <!-- END_TF_DOCS -->, in this file. I'm adding the template in now just because it is our convention for examples.


Update: I didn't notice that I was behind main where the generated section had already been added. rebased.

@displague displague force-pushed the nutanix-migration-review branch 2 times, most recently from 91648a2 to c73c523 Compare July 19, 2024 21:36
@codinja1188
Copy link
Contributor

@displague ,

#91

I verified and updated the changes. Using an odd Nutanix node count, I successfully provisioned clusters with node counts of 1 and 3. I followed the steps and performed a VM migration using a node count of 1."

Let me know if any adjustments are needed!

@displague displague changed the title WIP: updates from migration example qa/review updates from migration example qa/review Aug 12, 2024
@displague
Copy link
Member Author

METAL_AUTH_TOKEN and METAL_ORGANIZATION_ID secrets have been added

@displague displague merged commit 30e23fc into main Aug 12, 2024
1 check passed
@displague displague deleted the nutanix-migration-review branch August 12, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform Destroy Fails to Delete VLAN's
2 participants