Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save multi reactions (pathway, single, edge cases) to RDF #2237

Closed
ivanmaslow opened this issue Aug 15, 2024 · 1 comment · Fixed by #2379
Closed

Save multi reactions (pathway, single, edge cases) to RDF #2237

ivanmaslow opened this issue Aug 15, 2024 · 1 comment · Fixed by #2379
Assignees
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Test Cases Written Test cases has been written for that issue

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Aug 15, 2024

As a User, I want to have the ability to save different reactions in RDF format, So that I can easily exchange data with other applications that use the same format.

Acceptance Criteria:

  • User can save any kind of pathway or single reactions to RDF
  • Save to RDF option will be available always.
  • In cases, if there will be no reactions found - error should be displayed while saving to RDF.
  • Static objects and reagents should be ignored.
  • Separate molecules should be merged on Save or Layout actions to the nearest reactant/product of reaction or empty place near arrow without reactant/product
  • After saving to the RDF file, the ordering of separate cascade reactions in the RDF file should be the same as on Canvas, so after loading the saved RDF file the user will see the same order
@ivanmaslow ivanmaslow added MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Cascade reactions labels Aug 15, 2024
@ivanmaslow ivanmaslow changed the title [Indigo] Save multi reactions (pathway, single, edge cases) to RDF Save multi reactions (pathway, single, edge cases) to RDF Aug 15, 2024
@AlexeyGirin AlexeyGirin modified the milestone: Backlog Aug 23, 2024
@even1024 even1024 linked a pull request Sep 16, 2024 that will close this issue
7 tasks
@ivanmaslow ivanmaslow added the Test Cases Written Test cases has been written for that issue label Oct 10, 2024
@ivanmaslow
Copy link
Collaborator Author

ivanmaslow commented Oct 11, 2024

Exploratory testing is completed on RC Remote environment:

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-04; 18:45:04
  • Indigo Version 1.25.0-rc.1.0-g704673fcb-x86_64-linux-gnu-11.2.1
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.100 (Official Build) (64-bit)

Tasks below are tested too in scope of this task:

Points below are covered during testing, tests are updated:

  • New RDF V2000/V3000 options are added to file format dropdown:
    image

  • If no arrows are on Canvas and the user selects RDF V2000/V3000, an error appears:
    image

  • User can save different types of reactions (single, cascade, combinations) to RDF V2000/V3000, structure of file is displayed on preview:
    image

  • Reactions with Multi-Tailed Arrow, single arrow can be loaded from ket, RDF or added by tools and after that saved to RDF V2000/V3000

  • Single reactions with pluses (1) can be saved to RDF, but after loading they will be displayed with Multi-Tailed arrow, products will be merged (2):
    image

  • The error is displayed if user tries to save Multi-Tailed arrow to one of not appropriate formats SDF V2000, SDF V3000, InChlm, InChl AuxInfo, InchlKey:
    image

During exploratory testing a huge part of tests fail because of opened defects, they will be fixed according to priority and selected milestones. Retesting is required after fixing, because the core functionality is affected:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Test Cases Written Test cases has been written for that issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants