Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated $RDFILE $DATM records are displayed on save preview for RDF V2000/V3000 formats on Remote environment #2543

Closed
ivanmaslow opened this issue Oct 9, 2024 · 5 comments
Closed

Duplicated $RDFILE $DATM records are displayed on save preview for RDF V2000/V3000 formats on Remote environment #2543

ivanmaslow opened this issue Oct 9, 2024 · 5 comments
Assignees
@even1024
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Milestone
Indigo-1.25.0-rc.5

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Oct 9, 2024 •
edited
Loading

Steps to Reproduce

  1. Open Remote Ketcher env
  2. Add an arrow to Canvas
  3. Click on Save as...
  4. Select RDF V2000 or V3000

Actual behavior

  • Duplicated $RDFILE $DATM records are on preview or in saved RDF file:
    image

Expected behavior

  • No duplicated $RDFILE $DATM are on preview or in saved RDF file

Environment details:

  • Tested on RC Remote env
  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-04; 18:51:40
  • Indigo Version 1.25.0-rc.1.0-g704673fcb-x86_64-linux-gnu-11.2.1
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)

Note:
@ivanmaslow ivanmaslow added Bug Priority: High Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Oct 9, 2024
@ivanmaslow ivanmaslow added this to the Indigo-1.25.0-rc.2 milestone Oct 9, 2024
@ivanmaslow ivanmaslow changed the title Duplicated $RDFILE $DATM records on save to RDF V2000/V3000 formats on Remote environment Duplicated $RDFILE $DATM records are displayed on save preview for RDF V2000/V3000 formats on Remote environment Oct 9, 2024
@ivanmaslow ivanmaslow mentioned this issue Oct 11, 2024
Closed
@yauhen-karmyzau
Copy link
Collaborator

Fixed in Indigo-1.25.0-rc.2

@ivanmaslow
Copy link
Collaborator Author

Tested on Remote env:

  • Ketcher [Version 2.26.0-rc.3] Build at 2024-10-16; 14:42:10
  • Indigo Version 1.25.0-rc.2.0-g867ae250b-x86_64-linux-gnu-11.2.1
  • Desktop, Windows 11 Enterprise
  • Chrome Version 130.0.6723.59 (Official Build) (64-bit)

No duplicated records during saving to RDF V2000/V3000, but V3000 doesn't work on Remote env:
image
image

@ivanmaslow ivanmaslow mentioned this issue Oct 18, 2024
Closed
@ivanmaslow
Copy link
Collaborator Author

Can't be tested because of related issue - epam/ketcher#5814

@ivanmaslow
Copy link
Collaborator Author

The fix is successfully verified on uat remote env:

  • Ketcher [Version 2.26.0-rc.8] Build at 2024-11-07; 12:00:43
  • Indigo Version 1.25.0-rc.2.0-g867ae250b-x86_64-linux-gnu-11.2.1
  • Desktop, Windows 11 Enterprise
  • Chrome Version 130.0.6723.116 (Official Build) (64-bit)

There are no duplicated $RDFILE $DATM records on save for RDF V2000/V3000 formats:
image
image

@ivanmaslow
Copy link
Collaborator Author

Moved to Done according to the comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@even1024 even1024

Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Projects
None yet
Milestone
Indigo-1.25.0-rc.5
Development

No branches or pull requests
4 participants
@even1024 @AlexeyGirin @ivanmaslow @yauhen-karmyzau