Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can't correctly save (or make a layout) to RDF/RXN reaction several products or with separate positioned molecules #2412

Open
ivanmaslow opened this issue Sep 20, 2024 · 0 comments
Assignees
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Sep 20, 2024

Steps to Reproduce 1

  1. Add to Canvas reaction 3:3 with 3 reactants and 3 products:
    rdf-rxn-v2000-reaction-3x3-new.zip:
    image
  2. Click on Save to RDF/RXN

Actual Result

  • The second product is selected as only one product as it intersects by the continuation of the arrow, all other elements are considered reactants, so 5:1 reaction is displayed on Save:
    image
  • If the user tries to add this reaction to Canvas, 5:1 reaction is displayed:
    image

Expected Result

  • 3:3 reaction should be saved to the RDF/RXN file, the nearest products should be merged together

Environment details

  • Tested on CI-CD 2237-detect-pathway SA environment
  • Ketcher [Version 2.25.0-rc.2] Build at 2024-09-20; 03:00:51
  • Indigo Version 1.25.0-dev.1.57-gdf86cde5-wasm32-wasm-clang-12.0.0
  • Windows 11 Enterprise
  • Chrome Version 129.0.6668.59 (Official Build) (64-bit)

Notes

@ivanmaslow ivanmaslow added MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Cascade reactions Bug Priority: High labels Sep 20, 2024
@ivanmaslow ivanmaslow changed the title User can't correctly save to RDF/RXN reaction with several products Preview: User can't correctly save to RDF/RXN reaction with several products Sep 20, 2024
@ivanmaslow ivanmaslow added this to the Indigo-1.25.0-rc.1 milestone Sep 23, 2024
@ivanmaslow ivanmaslow changed the title Preview: User can't correctly save to RDF/RXN reaction with several products Preview: User can't correctly save to RDF/RXN reaction with several products or with separate positioned molecules Sep 30, 2024
@ivanmaslow ivanmaslow changed the title Preview: User can't correctly save to RDF/RXN reaction with several products or with separate positioned molecules User can't correctly save to RDF/RXN reaction with several products or with separate positioned molecules Oct 4, 2024
@ivanmaslow ivanmaslow changed the title User can't correctly save to RDF/RXN reaction with several products or with separate positioned molecules User can't correctly save (or make a layout) to RDF/RXN reaction several products or with separate positioned molecules Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Projects
None yet
Development

No branches or pull requests

4 participants