Lot of Website improvements #49
Conversation
mathieucarbou
changed the title
|
Blog post page: Mobile view of blog post page List of blog posts Ugly RSS/Atom Feed Resources page Tag page And I won't show you the generated sitemap at /sitemap.xml :P |
| @@ -10,6 +10,10 @@ | |||
| <span> </span> | |||
| <a href="/documentation/"><button type="button" class="btn btn-lg btn-primary"><i class="fa fa-book"></i> Documentation</button></a> | |||
| <span> </span> | |||
| <a href="/resources/"><button type="button" class="btn btn-lg btn-primary"><i class="fa fa-external-link-square"></i> Resources</button></a> | |||
| <span> </span> | |||
| <a href="/resources/"><button type="button" class="btn btn-lg btn-primary"><i class="fa fa-rss-square"></i> Ehcache Blog</button></a> | |||
There was a problem hiding this comment.
I think there are too many top-level menu items now.
What about putting resources under "docs" and having a "blogs" with "ehcache blog" and "terracotta blog" under it?
There was a problem hiding this comment.
Actually I agree with you but I don't know the answer because when discussing with @ljacomet we decided to put resources there. I sincerely don't know now if it is better to move it or change the CSS to improve the font / space or anything else.
The issue currently is that the top bar is too long and on smaller resolution, the right side comes below the left side and it's ugly.
I'll change so that we can test!
There was a problem hiding this comment.
I agree with the sizing issue. I would indeed put the two blog sections under a single menu item.
For the rest, I believe having doc as a direct link remains interesting.
Could we group resources and downloads under a single menu item?
|
Nice work - thanks for doing it. |
|
Does this fully replace #38 ? |
| --- | ||
| layout: post | ||
| title: "New Website" | ||
| headline: "The new Ehcache website is LIVE! Checkout its first post..." |
There was a problem hiding this comment.
We don't actually want to commit this file, right?
There was a problem hiding this comment.
It's just for tests - What I would suggest is to set hidden: true. It won't appear in the website and not in the RSS feed, and it would still be there as an example.
|
In order to build, I had to install |
|
@mathieucarbou Thanks a ton for the work - love it! |
|
@ljacomet @jhouserizer : here is what it looks like by moving resources under Community: |
| {% if site.disqus_shortname %} | ||
| <script type="text/javascript"> | ||
| /* * * CONFIGURATION VARIABLES: EDIT BEFORE PASTING INTO YOUR WEBPAGE * * */ | ||
| var disqus_shortname = '{{ site.disqus_shortname }}'; // required: replace example with your forum shortname |
There was a problem hiding this comment.
Should this be edited before enabling disqus?
There was a problem hiding this comment.
I created a Disqus channel named ehcache but it is on my account.
I would prefer to delete it so that we create the room from another much more official user. do we have one ? Or we use @jhouserizer or @ljacomet account ?
UPDATE: the idea would be to have one terracotta account, and then we can add seevral moderators (users) or admins.
|
@ljacomet BTW, Did you see this ? https://github.com/blog/2165-github-pages-to-upgrade-to-jekyll-3-1-4 |
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| // Our variables | |||
| $base-font-family: Helvetica, Arial, sans-serif; | |||
| $base-font-size: 16px; | |||
| $base-font-size: 16; | |||
There was a problem hiding this comment.
Saw a font size difference - might this be the guilty change? If the px needs to go, maybe try with 18 as the base font size.
There was a problem hiding this comment.
yes but its a bug to set a variable with a px value because its not an int variabel anymroe and cannot be part of computations by sass (that's why i removed the px).
Instead we should add the px suffx when we use the variable.
There was a problem hiding this comment.
NB: its a bug in the mixins thing
|
New screenshot: |
FYI @ljacomet @jhouserizer
Added:
Tested on some mobile devices.