This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Add source address to UAttributes #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelamudMichael
approved these changes
Feb 8, 2024
PLeVasseur
reviewed
Feb 8, 2024
sophokles73
reviewed
Feb 8, 2024
uprotocol/uattributes.proto
Outdated
|
|
||
| // The correlation ID (UUDI) passed for response type messages to corelate the | ||
| // response to a request. | ||
| optional UUID reqid = 8; | ||
| optional UUID reqid = 9; |
There was a problem hiding this comment.
optional keyword can be removed FMPOV
tamarafischer
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Personally I don't think these changes are really needed and are driving the people actually using and writing code to the protocol to drink!
That said, what is another change in the everchanging land of software development.
That said, if everyone really feels this is needed you have my plus 1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#101