Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function parameters of UTransport trait #30

Conversation

sophokles73
Copy link
Contributor

The documentation of the "send" function's parameters has been
adapted to match the semantics of the properties of UMessage.

Copy link

@stevenhartley stevenhartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hold off on this change as I work to fix the UTransport issue you've identified and we need to cleanup in core-api and all the language libraries.

@sophokles73
Copy link
Contributor Author

@stevenhartley Can you create a new tag in the up-core-api repository once eclipse-uprotocol/up-core-api#102 has been merged so that I can update this PR to pull in the changes from the protos?

@sophokles73 sophokles73 force-pushed the fix_utransport_send_documentation branch from 31fca6e to e4a3977 Compare February 12, 2024 13:15
The documentation of the "send" function's parameters has been
adapted to match the semantics of the properties of UMessage.
@sophokles73 sophokles73 force-pushed the fix_utransport_send_documentation branch from e4a3977 to 0c47107 Compare February 15, 2024 09:42
Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73
Copy link
Contributor Author

@stevenhartley can you merge this?

@stevenhartley stevenhartley merged commit c8ac024 into eclipse-uprotocol:main Feb 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants