-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AOT tests in nightly #6065
Merged
Merged
Fix AOT tests in nightly #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
Nov 19, 2024
tests/Microsoft.DotNet.Docker.Tests/TestScenarios/ConsoleAppScenario.cs
Outdated
Show resolved
Hide resolved
mthalman
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I have a pending comment on #6063 which this PR depends on.
Removed the duplicate commit with a rebase. |
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built off of Accept more types of failures when retrying HTTP requests in tests (#6063) since that change was necessary for more reliable local testing. That's commit 3f88859.
Fixes #6049
Basically, once the test filtering was fixed in 1c0e89d, some AOT tests were failing. Here is a summary of what was happening:
console
template. For web tests, there is thewebapiaot
template. There is no equivalent non-web template so we defaulted to theconsole
template. Since theconsole
template does not have AOT-specific MSBuild properties in its project file, this test was failing when it tried to run. It complained there was no .NET installation (duh).There should be follow-up work to:
aot
images #6066After review/merge, I'll file issues for the above two scenarios.