Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AOT tests in nightly #6065

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Fix AOT tests in nightly #6065

merged 6 commits into from
Nov 19, 2024

Conversation

lbussell
Copy link
Contributor

@lbussell lbussell commented Nov 19, 2024

This PR is built off of Accept more types of failures when retrying HTTP requests in tests (#6063) since that change was necessary for more reliable local testing. That's commit 3f88859.

Fixes #6049

Basically, once the test filtering was fixed in 1c0e89d, some AOT tests were failing. Here is a summary of what was happening:

  • AOT scenario tests were running on non-AOT images which was failing.
    • This is resolved by filtering test data by variant.
  • Self-contained publish scenario tests were running on AOT images which will never work since AOT images don't contain the correct dependencies.
  • Console app "AOT" scenario test was failing
    • This is because we were using the console template. For web tests, there is the webapiaot template. There is no equivalent non-web template so we defaulted to the console template. Since the console template does not have AOT-specific MSBuild properties in its project file, this test was failing when it tried to run. It complained there was no .NET installation (duh).
    • I removed the scenario since it was never functional and it needs a re-think.

There should be follow-up work to:

After review/merge, I'll file issues for the above two scenarios.

Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I have a pending comment on #6063 which this PR depends on.

@lbussell
Copy link
Contributor Author

Note that I have a pending comment on #6063 which this PR depends on.

Removed the duplicate commit with a rebase.

@lbussell lbussell merged commit 1f9b6e5 into dotnet:nightly Nov 19, 2024
107 checks passed
@lbussell
Copy link
Contributor Author

Filed the two follow-up issues: #6066 and #6067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants