Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an AOT console app test #6067

Closed
lbussell opened this issue Nov 19, 2024 · 5 comments
Closed

Add an AOT console app test #6067

lbussell opened this issue Nov 19, 2024 · 5 comments

Comments

@lbussell
Copy link
Contributor

See Fix AOT tests in nightly (#6065) for context.

Currently, our only AOT test is using the webapiaot sample. This is great, but we don't have any equivalent for a non-ASP.NET Core AOT app. We may find it valuable to add such a test.

This gets complicated because there is not a pre-made AOT sample other than webapiaot that I'm aware of. Therefore, the next best approach would be to take the console sample and modify its project or source files.

@mthalman
Copy link
Member

Pinging @eerhardt to see if he has any input here.

@lbussell
Copy link
Contributor Author

webapiaot may also be sufficient enough for a sanity test of AOT functionality. If so, then we could just close this as not planned. It just wouldn't be symmetrical with our fx-dependent tests.

@eerhardt
Copy link
Member

This gets complicated because there is not a pre-made AOT sample other than webapiaot that I'm aware of. Therefore, the next best approach would be to take the console sample and modify its project or source files.

We have 2 other templates that work with native AOT out of the box:

  • dotnet new console --aot
  • dotnet new worker --aot

Currently, our only AOT test is using the webapiaot sample. This is great, but we don't have any equivalent for a non-ASP.NET Core AOT app. We may find it valuable to add such a test.

I'm wondering what the value would be here. Can you describe what a plain console app would cover over the webapiaot template?

@lbussell
Copy link
Contributor Author

Can you describe what a plain console app would cover over the webapiaot template?

My thinking is that it could better isolate issues between ASP.NET itself and the AOT support of our images. For example, if we had some kind of misconfiguration in our image, and the console --aot sample is working and webapiaot is not, it's likely something to do with our ASP.NET configuration and not the AOT compilation.

If you don't think that scenario is likely, then running webapiaot alone would cover the most functionality of the three samples from what I can see.

@lbussell
Copy link
Contributor Author

[Triage] Closing as not planned since the webapiaot sample should provide sufficient coverage for AOT scenarios.

@lbussell lbussell closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Docker Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants