-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source-build should also use the release runtime. #46299
Conversation
Hi @crummel. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the opposite of what you want; lines in the project files will "lose" to those in the src/Tools/Directory.Build.targets file. Please remove the $(TargetLatestDotNetRuntime)
setting from src/Tools/Directory.Build.targets and add it to the other projects under src/Tools/ (not these three).
Our default for all projects in the repo is $(TargetLatestDotNetRuntime) == true
. It's just tool projects that ship independently of the SDK we need to special case. Note most (all❔) of those projects aren't source-built and won't need the $(DotNetSourceBuild)
part of the condition. (Side note: you have a typo in that part of the condition.)
@dsplaisted or @marcpopMSFT please confirm I'm correct that tools packaged only for inclusion in the SDK should align their dependencies w/ everything else in the SDK.
|
@marcpopMSFT I was less worried about the runtime configuration than |
I found a way to do this in source-build without the ASP.NET patch, sorry for the noise and thanks for taking a look. |
Hi @crummel. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
This is attempting to fix dotnet/source-build#3146. Source-build produces a stabilized runtime version which should filter down into ASP.NET and other repos. In #43937 we made changes in ASP.NET to support using only the non-portable (i.e. RID-specific) version of this runtime but this doesn't appear to have worked for the projects in
src/Tools
:I wanted to open this as a draft to get any advice and also to make sure that I don't break the non-source-build ASP.NET with my source-build fix.