-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove source-build manipulation of stable version. #15121
Conversation
6967049
to
9dc83cb
Compare
680e32d
to
1bea560
Compare
...Build/tarball/patches/aspnetcore/0001-Source-build-should-also-use-the-release-runtime.patch
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the impact of this in regards to the OverrideBootstrapVersions.props file? Does this file remain until the next release where the correct versions will be produced? If that's the case have you validated the file can be removed with these changes?
...Build/tarball/patches/aspnetcore/0001-Source-build-should-also-use-the-release-runtime.patch
Outdated
Show resolved
Hide resolved
I approved but then noticed the CI failure. The CI failure seems related to the patch. |
2796175
to
64974af
Compare
Yes, removing the OverrideBootstrapVersions.props will have to wait until we have a PSB with the correct versions in it. I verified that the artifacts and PVP in the PSB produced by this build is the expected 7.0.2 version and I'll try to kick off a build with this same change using those artifacts. The OSX failure is unrelated; it's the same one we've been seeing everywhere. |
… we got, not the one we feed in.
Building with the artifacts failed - I removed the ExtraVersionProps but they are needed; they just need to be set to the correct version rather than the runtimeOutputVersion we construct. Kicking off another try at this. |
Added a note to dotnet/source-build#3129 that the OverrideBootstrapProps removal will also involve a fix in buildBootstrapPreviouslySB.csproj - OverrideBootstrapProps is used unconditionally there. Other than that it all looks good, I have a build working using the artifacts from the CI bulid as input for a |
These are expected to be the same version number and cause fewer problems for people who are building on RIDs that do not match our PSB RID.
I also updated dotnet/source-build#3231 as we discussed to be about eliminating the RID-specific variables throughout the product. |
Merging past the OSX failure - this is the persistent one we've been seeing everywhere. |
Fixes dotnet/source-build#3146.
ASP.NET backport PR: dotnet/aspnetcore#46299.