Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): use translated values for name and shortName #438

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Birkbjo
Copy link
Member

@Birkbjo Birkbjo commented Nov 14, 2024

Fixes https://dhis2.atlassian.net/browse/DHIS2-18420 . Also includes some various cleanup of list descriptors, and manage list view.

  • FixesIdentifiableFilter-width after UI-upgrade.
  • Also adds lastUpdated as part of the default available columns.
  • Use translated values for name and shortName
  • Remove shortName from default columns
    • This is not present on most objects, so Ive added this to objects that have it.
  • Manage view dialog: hide "Filter"-tab if no available filters are present
  • Manage view dialog: sort available columns/filters alphabetically.
  • Adds some missing translations for properties.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for dhis2-maintenance-app-beta ready!

Name Link
🔨 Latest commit 0c4af7f
🔍 Latest deploy log https://app.netlify.com/sites/dhis2-maintenance-app-beta/deploys/674898cbfe9ad100089c6a61
😎 Deploy Preview https://deploy-preview-438--dhis2-maintenance-app-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Birkbjo Birkbjo changed the title fix: use displayName instead of name of lists fix: use displayName instead of name in lists Nov 14, 2024
@Birkbjo Birkbjo force-pushed the DHIS2-18420/fix-use-displayname-in-lists branch from 05eec95 to 2814b35 Compare November 28, 2024 15:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.61%. Comparing base (3c78f90) to head (2814b35).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   60.67%   60.61%   -0.06%     
==========================================
  Files         212      212              
  Lines        3372     3372              
  Branches      749      749              
==========================================
- Hits         2046     2044       -2     
- Misses       1318     1319       +1     
- Partials        8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Birkbjo Birkbjo changed the title fix: use displayName instead of name in lists fix(list): use translated values for name and shortName Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants