-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(list): use translated values for name and shortName #438
Open
Birkbjo
wants to merge
6
commits into
master
Choose a base branch
from
DHIS2-18420/fix-use-displayname-in-lists
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Birkbjo
changed the title
fix: use displayName instead of name of lists
fix: use displayName instead of name in lists
Nov 14, 2024
flaminic
approved these changes
Nov 14, 2024
Birkbjo
force-pushed
the
DHIS2-18420/fix-use-displayname-in-lists
branch
from
November 28, 2024 15:36
05eec95
to
2814b35
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 60.67% 60.61% -0.06%
==========================================
Files 212 212
Lines 3372 3372
Branches 749 749
==========================================
- Hits 2046 2044 -2
- Misses 1318 1319 +1
- Partials 8 9 +1 ☔ View full report in Codecov by Sentry. |
Birkbjo
changed the title
fix: use displayName instead of name in lists
fix(list): use translated values for name and shortName
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://dhis2.atlassian.net/browse/DHIS2-18420 . Also includes some various cleanup of list descriptors, and manage list view.
IdentifiableFilter
-width after UI-upgrade.lastUpdated
as part of the default available columns.