fix(list): add additional list filters for dataElementGroup/Sets #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Birkbjo
commented
Nov 28, 2024
| </div> | ||
| ) | ||
| } | ||
| export const Component = DefaultSectionList |
There was a problem hiding this comment.
I decided to reuse the default list component here. This was because useDataQuery would cause issues, and get the wrong data in the list. This happens because the query is dynamic, so the querykey resolves to { result: { resource: 'dataElements' } }, which causes react-query to resolve the data to the same that is in the dataElement-filter, and not the data you want for the list. Essentially leaking data from another source.
Dynamic queries ( params: (params => params)) is very dangerous for this reason, we should not use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #438 , and we should merge that before this.