feat(crypto): CRP-2624 Move tECDSA/tSchnorr/vetKD fake canister to separate repo #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altkdf
previously approved these changes
Nov 11, 2024
Merged
marc0olo
previously approved these changes
Nov 22, 2024
|
Looks like we need another round of reviews here because Github "dismissed stale reviews" when I merged the master branch to resolve merge conflicts. |
altkdf
approved these changes
Nov 25, 2024
marc0olo
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to move the tECDSA/tSchnorr/vetKD mock/fake canister to a separate repository, as it is not really an example dapp, so this example dapp is deleted again. Originally, the code was added in #1029.
The new repository is https://github.com/dfinity/chainkey-testing-canister.