Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix links #1055

Merged
merged 1 commit into from
Nov 22, 2024
Merged

docs: fix links #1055

merged 1 commit into from
Nov 22, 2024

Conversation

marc0olo
Copy link
Member

  • wrong LICENSE file name/reference lead to a broken link in the portal URL check
  • github issue link didn't make sense

@marc0olo marc0olo requested a review from a team as a code owner November 22, 2024 17:00
@marc0olo marc0olo mentioned this pull request Nov 22, 2024
Open
7 tasks
@altkdf
Copy link
Contributor

altkdf commented Nov 22, 2024

Thanks for looking into this @marc0olo. This example will be (re)moved though #1042.

@marc0olo
Copy link
Member Author

@altkdf thanks for pointing that out. mhh, can we somehow get the conflicts in the other branch fixed and get it merged as soon as possible?

otherwise it would be great to just approve this now so that we are unblocked in terms of getting the docs updated in the portal.

I do not think it is very urgent, so I am also fine just closing this PR here 😅

I didn't know about the sideeffects with the portal repo. so we should always be careful when linking between markdowns here in the examples repo

altkdf
altkdf approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@altkdf altkdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's just approve this PR :)

@marc0olo marc0olo merged commit 755cff4 into master Nov 22, 2024
4 checks passed
@marc0olo marc0olo deleted the fix-broken-links branch November 22, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altkdf altkdf altkdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc0olo @altkdf