Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add interface to manage integrations #240

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Conversation

nemunaire
Copy link
Collaborator

@nemunaire nemunaire commented Jun 1, 2023

Hi!

I would like to introduce Google Drive integration, but this requires to retrieve an oauth token to access the Google API. The easiest way to retrieve the token is by letting the user making the authentication in its browser and then retrieve the token, so I first introduce an interface to manage integrations, based on the user management page.

Second commit is to sort integrations alphabetically.

image
image

internal/ui/handlers.go Fixed Show fixed Hide fixed
internal/ui/handlers.go Fixed Show fixed Hide fixed
internal/ui/handlers.go Fixed Show fixed Hide fixed
internal/ui/handlers.go Fixed Show fixed Hide fixed
internal/ui/handlers.go Fixed Show fixed Hide fixed
@nemunaire
Copy link
Collaborator Author

I just rebase on the new UI

@nemunaire nemunaire requested a review from ddvk November 17, 2024 10:50
@ddvk
Copy link
Owner

ddvk commented Nov 17, 2024

ah, i should've merged before I changed the ui :), there is one small conflict

@nemunaire
Copy link
Collaborator Author

No problem, conflict solved!

@ddvk ddvk merged commit 743916c into ddvk:master Nov 17, 2024
4 checks passed
@ddvk
Copy link
Owner

ddvk commented Nov 17, 2024

btw, allowing editing of the localfs path is not optimal as in theory someone could do path traversal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants