Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Copy get_key_url from datalad.support.s3 #143

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Jun 6, 2024

datalad/datalad#7575 is failing because the crawler wants to import a function that uses boto objects.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.53%. Comparing base (2929e3b) to head (a636bd3).

Files Patch % Lines
datalad_crawler/nodes/s3.py 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   77.56%   77.53%   -0.04%     
==========================================
  Files          60       60              
  Lines        4721     4731      +10     
  Branches      956      959       +3     
==========================================
+ Hits         3662     3668       +6     
- Misses        895      898       +3     
- Partials      164      165       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit 9ccfe0e into datalad:master Jun 6, 2024
6 of 8 checks passed
@yarikoptic
Copy link
Member

THANK YOU @effigies

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Jun 6, 2024
@effigies effigies deleted the boto3-compat branch June 6, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants