Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to boto3 #142

Open
yarikoptic opened this issue Jun 6, 2024 · 1 comment
Open

Switch to boto3 #142

yarikoptic opened this issue Jun 6, 2024 · 1 comment

Comments

@yarikoptic
Copy link
Member

It is to happen for datalad core in coming minor release

/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datalad_crawler/nodes/s3.py:21: in <module>
53
    from datalad.support.s3 import get_key_url
54
E   ImportError: cannot import name 'get_key_url' from 'datalad.support.s3' (/home/runner/work/datalad/datalad/datalad/support/s3.py)

and also there is some direct use of boto here:

datalad_crawler/nodes/s3.py:from boto.s3.key import Key
datalad_crawler/nodes/s3.py:from boto.s3.prefix import Prefix
datalad_crawler/nodes/s3.py:from boto.s3.deletemarker import DeleteMarker
setup.py:        'boto',  # used directly by datalad_crawler/nodes/s3.py

so meanwhile we would need to restrict for crawler to have datalad < 1.1.0

@effigies
Copy link
Contributor

effigies commented Jun 6, 2024

The ImportError is fixed here: #143

That doesn't mean that use of the S3Downloader is working correctly. It isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants