imp: benchmarking v1 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdtrk
approved these changes
Aug 17, 2024
Comment on lines
+81
to
+101
| func abiEncodePacket(packet ics26router.IICS26RouterMsgsPacket) ([]byte, error) { | ||
| structType, err := abi.NewType("tuple", "", []abi.ArgumentMarshaling{ | ||
| {Name: "sequence", Type: "uint32"}, | ||
| {Name: "timeoutTimestamp", Type: "uint64"}, | ||
| {Name: "sourcePort", Type: "string"}, | ||
| {Name: "sourceChannel", Type: "string"}, | ||
| {Name: "destPort", Type: "string"}, | ||
| {Name: "destChannel", Type: "string"}, | ||
| {Name: "version", Type: "string"}, | ||
| {Name: "data", Type: "bytes"}, | ||
| }) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| args := abi.Arguments{ | ||
| {Type: structType}, | ||
| } | ||
|
|
||
| return args.Pack(packet) | ||
| } |
There was a problem hiding this comment.
Packet structure might change in the future, so it would be better we we could somehow use the auto-generated code here. But I will not block merging this PR
There was a problem hiding this comment.
Yeah, I wanted that as well, but I couldn't figure out how to get this from the ABI. The only alternative I found was some other weird parsing that seemed more obfuscated and error prone. This way is easy to read at least, but I do agree that it would be best if it came from the source itself. Maybe there is a way! For now, I created an issue for it: #46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.