Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto-generated code/ABI for marshalling Packet in e2e fixtures #46

Open
gjermundgaraba opened this issue Aug 17, 2024 · 0 comments
Open
Labels
nice to have testing Issues related to testing

Comments

@gjermundgaraba
Copy link
Contributor

The Packet that is marshalled in the e2e fixture is currently manually created by creating a new ABI type. This would cause issues if Packet struct ever changes (and might only give errors later when the fixtures are used in the solidity tests).

The ideal solution here would be to use something that is generated from the solidity code. Perhaps there is a way to use the ABI from ICS26Router to get the struct from there.

Reference to the discussion: #44 (comment)

@srdtrk srdtrk added the testing Issues related to testing label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have testing Issues related to testing
Projects
Status: No status
Development

No branches or pull requests

2 participants