Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rattler cache to /tmp when building linux from osx #2124

Merged
merged 9 commits into from
Nov 18, 2024

Conversation

hadim
Copy link
Member

@hadim hadim commented Nov 7, 2024

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

@hadim hadim requested a review from a team as a code owner November 7, 2024 16:55
@hadim
Copy link
Member Author

hadim commented Nov 7, 2024

Similar to conda-forge/staged-recipes#28119

@hadim
Copy link
Member Author

hadim commented Nov 7, 2024

LGTM

Copy link
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in build_steps.sh.tmpl, I think. There's a rattler-specific env var we are already using in other platforms, which would be preferred instead of the system-wide XDG setting.

@hadim
Copy link
Member Author

hadim commented Nov 7, 2024

This should go in build_steps.sh.tmpl, I think. There's a rattler-specific env var we are already using in other platforms, which would be preferred instead of the system-wide XDG setting.

I can move the logic to build_steps.sh.tmpl but I don't see any rattler env var I can re-use there. I am also not aware of another env var to set the rattler cache than XDG_CACHE_HOME.

Also, the current logic is specific to building linux from macOS with docker. Should I keep that same logic if moving to build_steps.sh.tmpl?

@jaimergp
Copy link
Member

jaimergp commented Nov 7, 2024

I am also not aware of another env var to set the rattler cache than XDG_CACHE_HOME.

See https://pixi.sh/v0.21.1/features/environment/#caching. I think RATTLER_CACHE_DIR applies here.

Also, the current logic is specific to building linux from macOS with docker.

Ah, ok, in that case build-locally is ok. Sorry!

@hadim
Copy link
Member Author

hadim commented Nov 7, 2024

I just tested locally and it does not work. It seems like RATTLER_CACHE_DIR only works with pixi.

@hadim
Copy link
Member Author

hadim commented Nov 7, 2024

I opened a ticket at prefix-dev/rattler-build#1171

@hadim hadim marked this pull request as draft November 7, 2024 20:12
@hadim
Copy link
Member Author

hadim commented Nov 11, 2024

LGTM once a new rattler-build version is out. See prefix-dev/rattler-build#1171 (comment) for details

@hadim hadim marked this pull request as ready for review November 11, 2024 13:23
@jaimergp
Copy link
Member

Thanks! Ping me again once the new rattler-build is out!

@jaimergp
Copy link
Member

Looks like 0.31 is out. Is that what we need for the new env var? Reopening just in case.

@jaimergp jaimergp closed this Nov 18, 2024
@jaimergp jaimergp reopened this Nov 18, 2024
@hadim
Copy link
Member Author

hadim commented Nov 18, 2024

Let's wait for 0.31 to make it in https://github.com/conda-forge/rattler-build-feedstock

@hadim
Copy link
Member Author

hadim commented Nov 18, 2024

Actually for conda-smithy, you can merge @jaimergp !

news/rattler-cache.rst Outdated Show resolved Hide resolved
@jaimergp jaimergp merged commit 4c4402b into conda-forge:main Nov 18, 2024
2 checks passed
@hadim hadim deleted the rattler_cache branch November 18, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants