Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-1682 Display CorrelationId in Unexpected Error Page #1665

Merged
merged 18 commits into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/src/common/pages/UniversalUnexpected.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,9 @@
&__link {
margin-left: 0.25rem;
}

&__correlation-id {
font-weight: bold;
margin-bottom: 0px;
}
}
40 changes: 33 additions & 7 deletions frontend/src/common/pages/UniversalUnexpected.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,49 @@ import "./UniversalUnexpected.scss";
import { ONROUTE_WEBPAGE_LINKS } from "../../routes/constants";
import { ErrorPage } from "../components/error/ErrorPage";
import { CustomExternalLink } from "../components/links/CustomExternalLink";
import { useLocation } from "react-router-dom";

export const UniversalUnexpected = () => {
const { state } = useLocation();
if (!state?.correlationId) {
return (
<ErrorPage
errorTitle="Unexpected Error"
msgNode={
<div className="unexpected-error-msg">
<span className="unexpected-error-msg__text">Please return to</span>

<CustomExternalLink
className="unexpected-error-msg__link"
href={ONROUTE_WEBPAGE_LINKS.HOME}
>
onRouteBC
</CustomExternalLink>
</div>
}
/>
);
}
return (
<ErrorPage
errorTitle="Unexpected Error"
msgNode={
<div className="unexpected-error-msg">
<span className="unexpected-error-msg__text">
Please return to
If this problem persists, please email
</span>

<CustomExternalLink
className="unexpected-error-msg__link"
href={ONROUTE_WEBPAGE_LINKS.HOME}
>
onRouteBC
<br></br>
<span className="unexpected-error-msg__text">
the error reference number below to
</span>
<CustomExternalLink className="unexpected-error-msg__link">
[email protected]
</CustomExternalLink>

<p className="unexpected-error-msg__correlation-id">
{/** Display just the first segment of the correlation id */}
{state.correlationId.split("-")[0].toUpperCase()}
</p>
</div>
}
/>
Expand Down
7 changes: 5 additions & 2 deletions frontend/src/features/idir/company/IDIRCreateCompany.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
CreateCompanyRequest,
CompanyProfile,
} from "../../manageProfile/types/manageProfile";
import { AxiosError } from "axios";

/**
* The form for a staff user to create a company.
Expand Down Expand Up @@ -117,8 +118,10 @@ export const IDIRCreateCompany = React.memo(() => {
setClientNumber(() => clientNumber);
}
},
onError: () => {
navigate(ERROR_ROUTES.UNEXPECTED);
onError: (error: AxiosError) => {
navigate(ERROR_ROUTES.UNEXPECTED, {
state: { correlationId: error.response?.headers["x-correlation-id"] },
});
},
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,9 @@ export const IDIRPermitSearchRowActions = ({
alertType: "success",
});
} else {
navigate(routes.ERROR_ROUTES.UNEXPECTED);
navigate(routes.ERROR_ROUTES.UNEXPECTED, {
state: { correlationId: response.headers["x-correlation-id"] },
});
}
};

Expand Down
31 changes: 21 additions & 10 deletions frontend/src/features/manageProfile/apiManager/hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { useMutation, useQuery } from "@tanstack/react-query";
import { useAuth } from "react-oidc-context";
import { useContext, useEffect } from "react";
import { useNavigate } from "react-router";
import { AxiosResponse } from "axios";
import { AxiosError, AxiosResponse } from "axios";

import { IDPS } from "../../../common/types/idp";
import { Nullable } from "../../../common/types/common";
Expand Down Expand Up @@ -54,9 +54,7 @@ export const useCompanyInfoQuery = () => {
* @param companyId Id of the company to get the info for
* @returns Query object containing company info
*/
export const useCompanyInfoDetailsQuery = (
companyId: number,
) => {
export const useCompanyInfoDetailsQuery = (companyId: number) => {
return useQuery({
queryKey: ["companyInfo"],
queryFn: () => getCompanyInfoById(companyId),
Expand Down Expand Up @@ -268,12 +266,19 @@ export const useDeleteCompanyActiveUsers = () => {
const navigate = useNavigate();
return useMutation({
mutationFn: deleteCompanyActiveUsers,
onError: () => navigate(ERROR_ROUTES.UNEXPECTED),
onError: (error: AxiosError) => {
navigate(ERROR_ROUTES.UNEXPECTED, {
state: { correlationId: error.response?.headers["x-correlation-id"] },
});
},
onSuccess: (response: AxiosResponse) => {
const { data: companyUserResponse } = response;
const { data: companyUserResponse, headers } = response;

const { failure } = companyUserResponse as DeleteResponse;
if (failure?.length > 0) {
navigate(ERROR_ROUTES.UNEXPECTED);
navigate(ERROR_ROUTES.UNEXPECTED, {
state: { correlationId: headers["x-correlation-id"] },
});
}
},
});
Expand All @@ -287,12 +292,18 @@ export const useDeleteCompanyPendingUsers = () => {
const navigate = useNavigate();
return useMutation({
mutationFn: deleteCompanyPendingUsers,
onError: () => navigate(ERROR_ROUTES.UNEXPECTED),
onError: (error: AxiosError) => {
navigate(ERROR_ROUTES.UNEXPECTED, {
state: { correlationId: error.response?.headers["x-correlation-id"] },
});
},
onSuccess: (response: AxiosResponse) => {
const { data: companyUserResponse } = response;
const { data: companyUserResponse, headers } = response;
const { failure } = companyUserResponse as DeleteResponse;
if (failure?.length > 0) {
navigate(ERROR_ROUTES.UNEXPECTED);
navigate(ERROR_ROUTES.UNEXPECTED, {
state: { correlationId: headers["x-correlation-id"] },
});
}
},
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ import {
BCeIDUserRoleType,
BCeID_USER_ROLE,
} from "../../../../../common/authentication/types";
import { AxiosError } from "axios";
import { useNavigate } from "react-router-dom";
import { ERROR_ROUTES } from "../../../../../routes/constants";

export const MyInfoForm = memo(
({
Expand All @@ -29,6 +32,7 @@ export const MyInfoForm = memo(
setIsEditing: React.Dispatch<React.SetStateAction<boolean>>;
}) => {
const queryClient = useQueryClient();
const navigate = useNavigate();
const formMethods = useForm<UserInfoRequest>({
defaultValues: {
firstName: getDefaultRequiredVal("", myInfo?.firstName),
Expand Down Expand Up @@ -61,6 +65,11 @@ export const MyInfoForm = memo(
setIsEditing(false);
}
},
onError: (error: AxiosError) => {
navigate(ERROR_ROUTES.UNEXPECTED, {
state: { correlationId: error.response?.headers["x-correlation-id"] },
});
},
});

const onUpdateMyInfo = (data: UserInfoRequest) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
getDefaultRequiredVal,
} from "../../../../../common/helpers/util";
import { BCeID_USER_ROLE } from "../../../../../common/authentication/types";
import { AxiosError } from "axios";

/**
* Edit User form for User Management.
Expand Down Expand Up @@ -76,8 +77,10 @@ export const EditUserForm = memo(
*/
const updateUserInfoMutation = useMutation({
mutationFn: updateUserInfo,
onError: () => {
navigate(ERROR_ROUTES.UNEXPECTED);
onError: (error: AxiosError) => {
navigate(ERROR_ROUTES.UNEXPECTED, {
state: { correlationId: error.response?.headers["x-correlation-id"] },
});
},
onSuccess: (response) => {
if (response.status === 200) {
Expand All @@ -93,6 +96,10 @@ export const EditUserForm = memo(
selectedTab: BCEID_PROFILE_TABS.USER_MANAGEMENT,
},
});
} else {
navigate(ERROR_ROUTES.UNEXPECTED, {
state: { correlationId: response.headers["x-correlation-id"] },
});
}
},
});
Expand Down
12 changes: 8 additions & 4 deletions frontend/src/features/manageVehicles/components/list/List.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,13 @@ export const List = memo(
setIsDeleteDialogOpen(() => true);
}, []);

const handleError = () => {
const handleError = (correlationId?: string) => {
setIsDeleteDialogOpen(() => false);
navigate(ERROR_ROUTES.UNEXPECTED);
navigate(ERROR_ROUTES.UNEXPECTED, {
state: {
correlationId,
},
});
};

const onConfirmDelete = async () => {
Expand All @@ -177,7 +181,7 @@ export const List = memo(
const responseBody = response.data;
if (responseBody.failure.length > 0) {
// Delete action for some vehicles failed
handleError();
handleError(response.headers["x-correlation-id"]);
} else {
setIsDeleteDialogOpen(() => false);
snackBar.setSnackBar({
Expand All @@ -193,7 +197,7 @@ export const List = memo(
query.refetch();
}
} else {
handleError();
handleError(response.headers["x-correlation-id"]);
}
} catch {
handleError();
zgong-gov marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
11 changes: 11 additions & 0 deletions frontend/src/features/permits/hooks/cart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ import {
getCartCount,
removeFromCart,
} from "../apiManager/cart";
import { AxiosError } from "axios";
import { ERROR_ROUTES } from "../../../routes/constants";
import { useNavigate } from "react-router-dom";

const CART_KEY = "cart";
const CART_COUNT_KEY = "cart-count";
Expand All @@ -19,6 +22,7 @@ const CART_ITEM = "cart-item";
* @returns Mutation object for adding items to cart
*/
export const useAddToCart = () => {
const navigate = useNavigate();
return useMutation({
mutationFn: ({
companyId,
Expand All @@ -27,6 +31,13 @@ export const useAddToCart = () => {
companyId: number;
applicationIds: string[];
}) => addToCart(companyId, applicationIds),
onError: (error: AxiosError) => {
navigate(ERROR_ROUTES.UNEXPECTED, {
state: {
correlationId: error?.response?.headers["x-correlation-id"],
},
});
},
});
};

Expand Down
Loading
Loading