Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-1682 Display CorrelationId in Unexpected Error Page #1665

Merged
merged 18 commits into from
Nov 20, 2024
Merged

Conversation

krishnan-aot
Copy link
Collaborator

@krishnan-aot krishnan-aot commented Nov 13, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot changed the title Display CorrelationId in Unexpected Error Page ORV2-1682 Display CorrelationId in Unexpected Error Page Nov 13, 2024
Copy link

sonarcloud bot commented Nov 20, 2024

Copy link

sonarcloud bot commented Nov 20, 2024

Copy link

sonarcloud bot commented Nov 20, 2024

Copy link

sonarcloud bot commented Nov 20, 2024

Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
13.4% Coverage on New Code (required ≥ 80%)
8.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@krishnan-aot krishnan-aot merged commit c606867 into main Nov 20, 2024
20 of 22 checks passed
@krishnan-aot krishnan-aot deleted the erp2 branch November 20, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants