enhancement: user agent 2.1 #3001
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenfryherrerafeliz
force-pushed
the
feat_user_agent_2.1
branch
from
c1ae03a
to
8d081b1
Compare
yenfryherrerafeliz
force-pushed
the
feat_user_agent_2.1
branch
14 times, most recently
from
3cd174e
to
4905534
Compare
stobrien89
requested changes
Sep 25, 2024
| const FLEXIBLE_CHECKSUMS_REQ_CRC64 = "W"; | ||
| const FLEXIBLE_CHECKSUMS_REQ_SHA1 = "X"; | ||
| const FLEXIBLE_CHECKSUMS_REQ_SHA256 = "Y"; | ||
| /** @var int */ |
There was a problem hiding this comment.
Basically I was saying each var/docblock should be separated by a newline
yenfryherrerafeliz
force-pushed
the
feat_user_agent_2.1
branch
5 times, most recently
from
e4cd325
to
6b4b870
Compare
stobrien89
requested changes
Nov 6, 2024
yenfryherrerafeliz
force-pushed
the
feat_user_agent_2.1
branch
7 times, most recently
from
1160889
to
c77d08e
Compare
yenfryherrerafeliz
force-pushed
the
feat_user_agent_2.1
branch
3 times, most recently
from
c8c6ef9
to
64854e1
Compare
stobrien89
requested changes
Nov 13, 2024
stobrien89
approved these changes
Nov 20, 2024
| const FLEXIBLE_CHECKSUMS_REQ_CRC64 = "W"; | ||
| const FLEXIBLE_CHECKSUMS_REQ_SHA1 = "X"; | ||
| const FLEXIBLE_CHECKSUMS_REQ_SHA256 = "Y"; | ||
| /** @var int */ |
There was a problem hiding this comment.
Basically I was saying each var/docblock should be separated by a newline
This change provides: - A builder class for appending metrics - Default initialization of a metrics builder within command instantiation - Wraps user agent logic into a single middleware class - Adds middlewares into the different features from where metrics can be gather, to acomplish this purpose.
- Move the user agent middleware after the signing step in order to gather signature metrics. - Add request compression metric gathering. - Add specific testing for signatures. - Add specific testing for request compression. - Add specific testing for s3 encryption clients. - Add credentials metric gathering logic. - Add tests for credentials metrics. - Make existent credentials tests to work with the new field `source`. For example, for tests around profile credentials the source property for credentials MUST be `profile`. The default value for this field is `static`.
- Use static mapping instead of multiple if/else-ifs. - Remove the endpoint_id metric tracking since it was removed from the spec. - Make method's name to be verb based. - Remove the getMetricsBuilder from the CommandInterface.
- Add tests cases to cover credentials sets the correct source when resolved. - Fix the sso, sso_legacy, and process metrics. They should be all a profile based metric.
yenfryherrerafeliz
force-pushed
the
feat_user_agent_2.1
branch
from
0ac671a
to
eb1aa90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.