chore: add credentials->source tests

- Add tests cases to cover credentials sets the correct source when resolved. - Fix the sso, sso_legacy, and process metrics. They should be all a profile based metric.
aws · Nov 15, 2024 · 0ac671a · 0ac671a
1 parent f6ed0f9
commit 0ac671a
Show file tree

Hide file tree

Showing 6 changed files with 670 additions and 19 deletions.
diff --git a/src/Credentials/CredentialProvider.php b/src/Credentials/CredentialProvider.php
@@ -646,7 +646,7 @@ public static function process($profile = null, $filename = null)
                     $processData['SessionToken'],
                     $expires,
                     $accountId,
-                    CredentialSources::PROCESS
+                    CredentialSources::PROFILE_PROCESS
                 )
             );
         };
@@ -927,7 +927,7 @@ private static function getSsoCredentials($profiles, $ssoProfileName, $filename,
                 $ssoCredentials['sessionToken'],
                 $expiration,
                 $ssoProfile['sso_account_id'],
-                CredentialSources::SSO
+                CredentialSources::PROFILE_SSO
             )
         );
     }
@@ -988,7 +988,7 @@ private static function getSsoCredentialsLegacy($profiles, $ssoProfileName, $fil
                 $ssoCredentials['sessionToken'],
                 $expiration,
                 $ssoProfile['sso_account_id'],
-                CredentialSources::SSO_LEGACY
+                CredentialSources::PROFILE_SSO_LEGACY
             )
         );
     }

diff --git a/src/Credentials/CredentialSources.php b/src/Credentials/CredentialSources.php
@@ -16,7 +16,7 @@ final class CredentialSources
     const PROFILE = 'profile';
     const IMDS = 'instance_profile_provider';
     const ECS = 'ecs';
-    const SSO = 'sso';
-    const SSO_LEGACY = 'sso_legacy';
-    const PROCESS = 'process';
+    const PROFILE_SSO = 'profile_sso';
+    const PROFILE_SSO_LEGACY = 'profile_sso_legacy';
+    const PROFILE_PROCESS = 'profile_process';
 }
diff --git a/src/Credentials/Credentials.php b/src/Credentials/Credentials.php
@@ -41,7 +41,7 @@ public function __construct(
         $this->token = $token;
         $this->expires = $expires;
         $this->accountId = $accountId;
-        $this->source = $source;
+        $this->source = $source ?? CredentialSources::STATIC;
     }
 
     public static function __set_state(array $state)

diff --git a/src/MetricsBuilder.php b/src/MetricsBuilder.php
@@ -43,9 +43,9 @@ final class MetricsBuilder
     const CREDENTIALS_PROFILE_STS_WEB_ID_TOKEN = "q";
     const CREDENTIALS_HTTP = "z";
     const CREDENTIALS_IMDS = "0";
-    const CREDENTIALS_PROCESS = "w";
-    const CREDENTIALS_SSO = "s";
-    const CREDENTIALS_SSO_LEGACY = "u";
+    const CREDENTIALS_PROFILE_PROCESS = "v";
+    const CREDENTIALS_PROFILE_SSO = "r";
+    const CREDENTIALS_PROFILE_SSO_LEGACY = "t";
 
     /** @var int */
     private static $MAX_METRICS_SIZE = 1024; // 1KB or 1024 B
@@ -229,12 +229,12 @@ private function appendCredentialsMetric(
                 MetricsBuilder::CREDENTIALS_HTTP,
             CredentialSources::PROFILE_STS_WEB_ID_TOKEN =>
                 MetricsBuilder::CREDENTIALS_PROFILE_STS_WEB_ID_TOKEN,
-            CredentialSources::PROCESS =>
-                MetricsBuilder::CREDENTIALS_PROCESS,
-            CredentialSources::SSO =>
-                MetricsBuilder::CREDENTIALS_SSO,
-            CredentialSources::SSO_LEGACY =>
-                MetricsBuilder::CREDENTIALS_SSO_LEGACY,
+            CredentialSources::PROFILE_PROCESS =>
+                MetricsBuilder::CREDENTIALS_PROFILE_PROCESS,
+            CredentialSources::PROFILE_SSO =>
+                MetricsBuilder::CREDENTIALS_PROFILE_SSO,
+            CredentialSources::PROFILE_SSO_LEGACY =>
+                MetricsBuilder::CREDENTIALS_PROFILE_SSO_LEGACY,
         ];
         if (isset($credentialsMetricMapping[$source])) {
             $this->append($credentialsMetricMapping[$source]);