Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: make a newly added Network the default one #9708

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented Sep 19, 2024

Checkbox to make a newly added Network the default one in the Instance's Network tab

Description

This PR adds a checkbox into the Add Network dialogue to make the newly added network the default one in Instance's Network Tab. This will save users from performing an extra step to make the network the default one.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2024-09-19 11-13-08
Screenshot from 2024-09-19 11-13-19
Screenshot from 2024-09-19 11-13-22

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@abh1sar abh1sar marked this pull request as ready for review September 19, 2024 08:28
@abh1sar
Copy link
Collaborator Author

abh1sar commented Sep 19, 2024

@blueorangutan ui

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.81%. Comparing base (7d95952) to head (02be6a2).
Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #9708    +/-   ##
==========================================
  Coverage     15.81%   15.81%            
- Complexity    12553    12554     +1     
==========================================
  Files          5629     5629            
  Lines        492015   492028    +13     
  Branches      61440    62367   +927     
==========================================
+ Hits          77813    77823    +10     
- Misses       405879   405885     +6     
+ Partials       8323     8320     -3     
Flag Coverage Δ
uitests 4.48% <ø> (-0.01%) ⬇️
unittests 16.60% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9708 (QA-JID-452)

@abh1sar
Copy link
Collaborator Author

abh1sar commented Sep 19, 2024

@blueorangutan ui

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9708 (QA-JID-453)

@rohityadavcloud rohityadavcloud added this to the 4.20.1.0 milestone Sep 19, 2024
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok on qa

@DaanHoogland DaanHoogland changed the title UI: Checkbox to make a newly added Network the default one in the Ins… UI: make a newly added Network the default one Sep 20, 2024
Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested the Qa build,

Screenshot 2024-09-20 at 2 45 47 PM

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@kiranchavala
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copy link
Collaborator

@rajujith rajujith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoaoJandre JoaoJandre merged commit db2e89a into apache:main Nov 28, 2024
25 of 26 checks passed
@rohityadavcloud
Copy link
Member

@JoaoJandre @DaanHoogland some PRs targeting 4.20.1 are merged on main - should they go to 4.20 branch?

@JoaoJandre
Copy link
Contributor

@rohityadavcloud Considering that they were not targeting 4.19 (a maintenance branch), I assumed the authors wanted their changes to be made on the main branch directly. I'll fix the milestone. If the authors want their changes to be on the 4.20 branch, I volunteer to backport the PRs (#9930, #9708, #9956).

@JoaoJandre JoaoJandre removed this from the 4.20.1 milestone Nov 29, 2024
@JoaoJandre JoaoJandre added this to the 4.21.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants