-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for telugu language #9956
Add support for telugu language #9956
Conversation
63b8af5
to
4e9512a
Compare
4e9512a
to
af84752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@blueorangutan package |
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9956 +/- ##
=========================================
Coverage 15.80% 15.80%
- Complexity 12585 12586 +1
=========================================
Files 5627 5627
Lines 492343 492343
Branches 59694 59694
=========================================
Hits 77828 77828
Misses 405992 405992
Partials 8523 8523
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (no native telugu speaker!)
UI build: ✔️ |
@kiranchavala , please resolve the lint issue. |
Co-authored-by: dahn <[email protected]>
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@JoaoJandre @DaanHoogland some PRs targeting 4.20.1 are merged on main - should they go to 4.20 branch? |
@rohityadavcloud Considering that they were not targeting 4.19 (a maintenance branch), I assumed the authors wanted their changes to be made on the main branch directly. I'll fix the milestone. If the authors want their changes to be on the 4.20 branch, I volunteer to backport the PRs (#9930, #9708, #9956). |
This PR adds support for Telugu language in the Cloudstack Ui