Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for telugu language #9956

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

kiranchavala
Copy link
Contributor

@kiranchavala kiranchavala commented Nov 20, 2024

This PR adds support for Telugu language in the Cloudstack Ui

Screenshot 2024-11-20 at 4 55 17 PM

ui/package-lock.json Outdated Show resolved Hide resolved
.python-version Outdated Show resolved Hide resolved
@kiranchavala kiranchavala force-pushed the add-support-for-telugu-language branch 3 times, most recently from 63b8af5 to 4e9512a Compare November 20, 2024 15:22
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@sureshanaparti sureshanaparti added this to the 4.20.1 milestone Nov 20, 2024
@kiranchavala
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.80%. Comparing base (8a2c0f3) to head (6140f5b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9956   +/-   ##
=========================================
  Coverage     15.80%   15.80%           
- Complexity    12585    12586    +1     
=========================================
  Files          5627     5627           
  Lines        492343   492343           
  Branches      59694    59694           
=========================================
  Hits          77828    77828           
  Misses       405992   405992           
  Partials       8523     8523           
Flag Coverage Δ
uitests 4.04% <ø> (ø)
unittests 16.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (no native telugu speaker!)

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9956 (QA-JID-482)

@DaanHoogland
Copy link
Contributor

@kiranchavala , please resolve the lint issue.

@shwstppr
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9956 (QA-JID-483)

@JoaoJandre JoaoJandre merged commit 26095e2 into apache:main Nov 28, 2024
25 of 26 checks passed
@rohityadavcloud rohityadavcloud modified the milestones: 4.20.1, 4.21.0 Nov 29, 2024
@rohityadavcloud
Copy link
Member

@JoaoJandre @DaanHoogland some PRs targeting 4.20.1 are merged on main - should they go to 4.20 branch?

@JoaoJandre
Copy link
Contributor

@rohityadavcloud Considering that they were not targeting 4.19 (a maintenance branch), I assumed the authors wanted their changes to be made on the main branch directly. I'll fix the milestone. If the authors want their changes to be on the 4.20 branch, I volunteer to backport the PRs (#9930, #9708, #9956).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants