Narrow down shielding retry logic #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
==========================================
+ Coverage 74.32% 74.55% +0.23%
==========================================
Files 341 341
Lines 107401 107399 -2
==========================================
+ Hits 79828 80076 +248
+ Misses 27573 27323 -250 ☔ View full report in Codecov by Sentry. |
grarco
force-pushed
the
grarco/narrow-shielding-retry-logic
branch
from
a268799
to
03b3182
Compare
batconjurer
approved these changes
Nov 26, 2024
3 tasks
grarco
added
merge
mergify bot
added a commit
that referenced
this pull request
Nov 26, 2024
Narrow down shielding retry logic (backport #4071)
tzemanovic
added a commit
that referenced
this pull request
Nov 29, 2024
* maint-0.46: Namada libs 0.46.1 changelog: add #4117 exclude apps crate from libs release apps: don't use workspace version anymore add a script to release apps bins prefix libs release tag with "libs-" mv scripts/release.sh scripts/release_libs.sh add different commit msg for libs release add a different release config for apps Changelog Add a single CometBFT dummy validator mergify: move autosquash to queue_rules Adds debug trace for masp epochs in asset types Fix `gen_localnet.py` json exception Revert "ci(mergify): upgrade configuration to current format" Error match for shielding retry logic Changelog #4071 Refactors shielding retry logic Shielding retry logic only when masp vp rejects Improves implicit vp display Changelog #4083 Adds missing protocol params in logs Log the implicit vp in `query-protocol-parameters` mergify: backport 0.46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4045.
Ensures that the retry logic for a failed shielding tx hitting an epoch boundary is applied only when the MASP vp is the only one rejecting the tx and the error is among the expected ones.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo