Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow down shielding retry logic (backport #4071) #4092

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 26, 2024

Describe your changes

Closes #4045.

Ensures that the retry logic for a failed shielding tx hitting an epoch boundary is applied only when the MASP vp is the only one rejecting the tx and the error is among the expected ones.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4071 done by [Mergify](https://mergify.com).

(cherry picked from commit 922409d)
(cherry picked from commit 03b3182)
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (ad3be9c) to head (421dcd7).
Report is 5 commits behind head on maint-0.46.

Additional details and impacted files
@@             Coverage Diff             @@
##           maint-0.46    #4092   +/-   ##
===========================================
  Coverage       74.58%   74.58%           
===========================================
  Files             341      341           
  Lines          107484   107484           
===========================================
+ Hits            80162    80169    +7     
+ Misses          27322    27315    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco self-requested a review November 26, 2024 14:21
@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 26, 2024
@mergify mergify bot merged commit a3b1ec0 into maint-0.46 Nov 26, 2024
23 of 24 checks passed
@mergify mergify bot deleted the mergify/bp/maint-0.46/pr-4071 branch November 26, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant