Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: exclude protobuf sources #457

Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from
Open

clang-tidy: exclude protobuf sources #457

wants to merge 3 commits into from

Conversation

patrick-5546
Copy link

No description provided.

@patrick-5546
clang-tidy: exclude protobuf sources
dd4d429 
Signed-off-by: Patrick Creighton <[email protected]>
@patrick-5546
Change double to single quotes
8356d10 
Signed-off-by: Patrick Creighton <[email protected]>
@patrick-5546 patrick-5546 mentioned this pull request Oct 25, 2023
Open
3 tasks
@sloretz
Copy link
Contributor

sloretz commented Nov 2, 2023

This is a nice small PR. Would you be willing to implement it using AMENT_LINT_AUTO_FILE_EXCLUDE instead? (context: #386). That will allow you to filter generated protobuf files at the package level, and also help resolve #458.

@patrick-5546
Support AMENT_LINT_AUTO_FILE_EXCLUDE
0a99330 
Signed-off-by: Patrick Creighton <[email protected]>
@patrick-5546
Copy link
Author

patrick-5546 commented Nov 4, 2023 •
edited
Loading

@sloretz I haven't extensively tested it yet, but does this look something like what you are looking for? I mainly based it off of cpplint's implementation

@patrick-5546
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick-5546 @sloretz