New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ament clang tidy #180

Open

3 tasks

patrick-5546 opened this issue Oct 18, 2023 · 0 comments

Labels

Member

patrick-5546 commented Oct 18, 2023 •

edited

Loading

Purpose

Streamline our CI. Currently clang-tidy is a separate action, but after prerequisites are complete it can be merged into the ament-lint task.

Prerequisites

ament clang tidy bug fix is merged in: Clang tidy add extra arg option and return 1 when any error is catched. ament/ament_lint#452
ament clang tidy ignores protobuf files: clang-tidy: exclude protobuf sources ament/ament_lint#457
vscode ament task provider extension supports clang-tidy
- Create a PR in https://github.com/athackst/vscode-ament-task-provider to add support
  - Can use the PR adding mypy support as reference: Add support for mypy athackst/vscode-ament-task-provider#201

Changes

Use the clang tidy problem matcher in the vscode task
Merge clang-tidy action into ament-lint
Install ament clang tidy in base dev image

Resources

patrick-5546 added the infrastructure label

patrick-5546 added this to SOFT Project

github-project-automation bot moved this to Backlog in SOFT Project

patrick-5546 mentioned this issue

Update flake8 and clang-tidy linters #179

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment