Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure viewer for 0d hide the cell tab #522

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Structure viewer for 0d hide the cell tab #522

wants to merge 3 commits into from

Commits on Oct 3, 2023

  1. Not create cell for 0D 

    `_validate_and_fix_ase_cell` function is not needed anymore, since it add a
dummy cell to gas phase molecule. In the old AiiDA, there needed to be default
cell, otherwise StructureData would not work.
But that has been fixed so we should get rid of this login in AWB.

The fix in aiida-core was done here aiidateam/aiida-core#5341
and released in version 2.0 https://github.com/aiidateam/aiida-core/blob/main/CHANGELOG.md#v200---2022-04-27
    @unkcpz
    unkcpz committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    08b4a04 View commit details
    Browse the repository at this point in the history

  2. Refactoring: moving configuration_tabs to the create_tab function

    @unkcpz
    unkcpz committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    c6bf181 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. The lattice tab will be hidden

    @unkcpz
    unkcpz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    50e313d View commit details
    Browse the repository at this point in the history