Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure viewer for 0d hide the cell tab #522

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Structure viewer for 0d hide the cell tab #522

wants to merge 3 commits into from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 4, 2023 •
edited
Loading

fixes #351

  • unit test on the newly added feature.

@unkcpz
Not create cell for 0D
08b4a04 
`_validate_and_fix_ase_cell` function is not needed anymore, since it add a
dummy cell to gas phase molecule. In the old AiiDA, there needed to be default
cell, otherwise StructureData would not work.
But that has been fixed so we should get rid of this login in AWB.

The fix in aiida-core was done here aiidateam/aiida-core#5341
and released in version 2.0 https://github.com/aiidateam/aiida-core/blob/main/CHANGELOG.md#v200---2022-04-27
@unkcpz
Refactoring: moving configuration_tabs to the create_tab function
c6bf181
@unkcpz
The lattice tab will be hidden
50e313d
@unkcpz unkcpz marked this pull request as draft October 4, 2023 00:08
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a1b5134) 79.39% compared to head (50e313d) 79.84%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
+ Coverage   79.39%   79.84%   +0.44%     
==========================================
  Files          27       27              
  Lines        3849     3830      -19     
==========================================
+ Hits         3056     3058       +2     
+ Misses        793      772      -21
Flag Coverage Δ
python-3.10 79.84% <80.00%> (+0.44%) ⬆️
python-3.8 79.87% <80.00%> (+0.44%) ⬆️
python-3.9 79.87% <80.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tests/conftest.py 78.73% <100.00%> (+0.50%) ⬆️
tests/test_structures.py 100.00% <100.00%> (ø)
tests/test_viewers.py 100.00% <100.00%> (ø)
aiidalab_widgets_base/structures.py 77.93% <84.61%> (+3.04%) ⬆️
aiidalab_widgets_base/viewers.py 69.67% <69.44%> (-1.26%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz mentioned this pull request Oct 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide the Cell tab when the structure is not periodic
1 participant
@unkcpz