Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow file to run arm-based testing with sanitizers #649

Merged
merged 7 commits into from
May 10, 2024
Merged

Add workflow file to run arm-based testing with sanitizers #649

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a99ede
add workflow file to run arm-based testing with sanitizers
CarlosEduR May 4, 2024
70e6545
fix env parameter, move to parent
CarlosEduR May 4, 2024
4052093
update image used to checkout
CarlosEduR May 8, 2024
bad3152
Remove permissions declaration for testing purposes
CarlosEduR May 9, 2024
f909d67
Remove --output-on-failure for testing purposes
CarlosEduR May 9, 2024
1716753
Move test command to same step of build
CarlosEduR May 10, 2024
c6c94e3
Update aarch64.yml
anonrig May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .github/workflows/aarch64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Ubuntu aarch64 (GCC 11)
anonrig marked this conversation as resolved.
Show resolved Hide resolved

on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
- '**.md'
- 'docs/**'
push:
branches:
- main
paths-ignore:
- '**.md'
- 'docs/**'

permissions:
contents: read
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you specified that files could not be written, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just drop this permission step and see whether the permission issue resolved itself.

I am not quite sure why we specify permissions... :-/

Copy link
Member Author

@CarlosEduR CarlosEduR May 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, actually I was more trying to follow the pattern I saw in other files. Also, the workflow file you shared with me as an example, it actually does not contain any permissions. I was wondering if adding permissions to write could be an issue.


concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
shared: [ON, OFF]
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
- uses: uraimo/run-on-arch-action@v2
name: Build
id: runcmd
env:
CXX: g++-12
with:
arch: aarch64
githubToken: ${{ github.token }}
distro: ubuntu_latest
install: |
apt-get update -q -y
apt-get install -y cmake make g++ ninja-build
run: |
cmake -DADA_SANITIZE=ON -DADA_DEVELOPMENT_CHECKS=ON -DBUILD_SHARED_LIBS=${{matrix.shared}} -G Ninja -B build
cmake --build build -j=2
- name: Test
run: ctest --output-on-failure --test-dir build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could try removing --output-on-failure which might prevent ctest from creating logs, but I am not sure.

Loading