Add workflow file to run arm-based testing with sanitizers #649
Conversation
|
Running tests. |
|
Seems it failed... I just pushed an update, let's see how it goes. |
|
Running... |
|
@lemire hmm, it is still failing... Off the top of your head, do you have any idea? |
.github/workflows/aarch64.yml
Outdated
| - 'docs/**' | ||
|
|
||
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
So you specified that files could not be written, correct?
There was a problem hiding this comment.
I would just drop this permission step and see whether the permission issue resolved itself.
I am not quite sure why we specify permissions... :-/
There was a problem hiding this comment.
Yes, actually I was more trying to follow the pattern I saw in other files. Also, the workflow file you shared with me as an example, it actually does not contain any permissions. I was wondering if adding permissions to write could be an issue.
.github/workflows/aarch64.yml
Outdated
| cmake -DADA_SANITIZE=ON -DADA_DEVELOPMENT_CHECKS=ON -DBUILD_SHARED_LIBS=${{matrix.shared}} -G Ninja -B build | ||
| cmake --build build -j=2 | ||
| - name: Test | ||
| run: ctest --output-on-failure --test-dir build |
There was a problem hiding this comment.
Alternatively, we could try removing --output-on-failure which might prevent ctest from creating logs, but I am not sure.
|
It looks like a permission problem. I am not sure what the source of the issue is. |
|
I have never seen this error: |
|
Let us run the tests... |
.github/workflows/aarch64.yml
Outdated
| cmake -DADA_SANITIZE=ON -DADA_DEVELOPMENT_CHECKS=ON -DBUILD_SHARED_LIBS=${{matrix.shared}} -G Ninja -B build | ||
| cmake --build build -j=2 | ||
| - name: Test | ||
| run: ctest --test-dir build |
There was a problem hiding this comment.
This needs to be inside the previous step just like the s360x workflow.
|
@anonrig I suspect that the memory sanitizer is still busted. :-( It finds problems inside the standard library. (It is clearly unrelated to this PR.) |
|
hmm, I see the pipeline passed, but what I saw from logs: |
|
@CarlosEduR Yes. But at least we are now checking that things build, which is good. |
Fixes: #520