Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed List[str] annotation in delete_branch feature #2518

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Fixed List[str] annotation in delete_branch feature #2518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deeplake/util/version_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ def delete_branch(


def _delete_branch_and_commits(
branch_name: str, all_branch_commits: list[str], dataset, storage
branch_name: str, all_branch_commits: List[str], dataset, storage
) -> None:
"""
Physically deletes the given branch and list of commits from the version_control_info.json and versions directories.
Expand Down Expand Up @@ -401,7 +401,7 @@ def _delete_branch_and_commits(
).encode("utf-8")


def _find_branch_commits(branch_name: str, version_state: dict) -> list[str]:
def _find_branch_commits(branch_name: str, version_state: dict) -> List[str]:
"""
Returns a list of all commits used by the given branch
"""
Expand Down