Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed List[str] annotation in delete_branch feature #2518

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Aug 5, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes type annotation to avoid this error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/s/work/deeplake/deeplake/__init__.py", line 19, in <module>
    from .api.dataset import dataset as api_dataset
  File "/Users/s/work/deeplake/deeplake/api/dataset.py", line 9, in <module>
    from deeplake.auto.unstructured.image_classification import ImageClassification
  File "/Users/s/work/deeplake/deeplake/auto/unstructured/image_classification.py", line 13, in <module>
    from deeplake.core.dataset import Dataset
  File "/Users/s/work/deeplake/deeplake/core/dataset/__init__.py", line 1, in <module>
    from .dataset import Dataset  # type: ignore
  File "/Users/s/work/deeplake/deeplake/core/dataset/dataset.py", line 22, in <module>
    from deeplake.util.version_control import (
  File "/Users/s/work/deeplake/deeplake/util/version_control.py", line 372, in <module>
    branch_name: str, all_branch_commits: list[str], dataset, storage
TypeError: 'type' object is not subscriptable

@davidbuniat davidbuniat merged commit 4f6a2cb into main Aug 5, 2023
3 of 5 checks passed
@davidbuniat davidbuniat deleted the fix_list_type branch August 5, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants