Make ErrorInfo.fromValues’s signature correspond to its expectations
#1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1322/bundle-report
lawrence-forooghian
force-pushed
the
fix-signature-of-ErrorInfo-fromValues
branch
from
727fb78
to
ce33d1c
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1322/bundle-report
owenpearson
approved these changes
Jun 12, 2023
lawrence-forooghian
force-pushed
the
fix-signature-of-ErrorInfo-fromValues
branch
from
ce33d1c
to
480ba0d
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1322/bundle-report
lawrence-forooghian
force-pushed
the
fix-signature-of-ErrorInfo-fromValues
branch
from
480ba0d
to
c77b009
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1322/bundle-report
lawrence-forooghian
force-pushed
the
fix-signature-of-ErrorInfo-fromValues
branch
from
c77b009
to
c0af7bf
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1322/bundle-report
lawrence-forooghian
force-pushed
the
integration/v2
branch
from
7bea01e
to
b8e1ea3
Compare
It expects the received object to have certain keys of certain types, and throws an error if not. So, get the compiler’s help in enforcing this.
lawrence-forooghian
force-pushed
the
fix-signature-of-ErrorInfo-fromValues
branch
from
c0af7bf
to
e036148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It expects the received object to have certain keys of certain types, and throws an error if not. So, get the compiler’s help in enforcing this.