Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4122] v2.0.0 changelog #1656

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[ECO-4122] v2.0.0 changelog #1656

merged 1 commit into from
Mar 21, 2024

Conversation

VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Mar 1, 2024

Changelog is based on changes between e71ed5f...c02ec56 (latest main and integration/v2 diff as of March 21).

PRs that need to be added to the changelog when finished/reviewed and merged:

Please note that this is not an exhaustive list of tasks that need to be completed before the v2 release. This list contains only the user-facing PRs/tasks that must be added to the changelog.

Pull requests not included in this changelog (I considered them as Miscellaneous / Extras, non-user facing):

  • Use useLayoutEffect when calling .setOptions() in ChannelProvider #1706
  • Remove some lingering any from stats() param type #1705
  • Improve errors for incorrect constructor args #1702
  • Fix stray second arg to modular constructor #1701
  • Add migration guide for react hooks for ably-js v2 #1698
  • Change PresenceEnterResult to PresenceResult in react hooks #1697
  • Fix ably/modular can't be imported in node environment #1696
  • Fix lint warnings #1694
  • build: use esbuild for nodejs bundle #1691
  • Add documentation for skip parameter for hooks to React docs #1675
  • Add migration guide for v2 #1670
  • Document fallback transport mechanism in the context of network conditions for v2 #1664
  • Restore ClientOptions.plugins mechanism and use it for modular variant #1663
  • ci: don't check formatting in react workflow #1653
  • test: test ux improvements #1652
  • Move React.createContext outside of components in react-hooks #1643
  • Improve logs for react package test in test:package #1639
  • Document our continued support for v1 #1634
  • Refactor nodejs http util class #1627
  • Fix missing ably/react export from ably package on v2 branch #1625
  • Fix ably import in react hooks #1624
  • Convert HTTP code to use promises #1603
  • Add better error handling for incorrect PLAYWRIGHT_BROWSER in runPlaywrightTests script #1595
  • Document that queryTime auth option requires Rest module #1593
  • Make modulereport print gzipped size too #1586
  • Add try/catch to _multiple_send to allow fast fail in case of errors #1585
  • Fix mocha web server process keeps running after failed playwright tests #1584
  • Fix multiple_send_binary_2_200 is failing intermittently in browser on v2 branch #1583
  • Improve IPlatformConfig #1563
  • build: use Ably as UMD lib name #1558
  • Remove callbacks part 1 #1541
  • Strip logging from modular variant of the SDK #1536
  • Correct tsc module settings for test:package #1521
  • Add stats to list of functionality gated off by Rest module #1517
  • Remove the existing plugins mechanism #1512
  • Add some regression testing for bundle size and included files #1507
  • Exclude PresenceMessage from BaseRealtime bundle #1505
  • Remove static stuff from *Message classes #1503
  • Add documentation for modular variant of library #1502
  • Add typings for the tree-shakable version of the library #1498
  • Remove remaining REST code from BaseRealtime #1496
  • Don’t populate DeviceDetails.toRequestBody by assignment #1494
  • Do e013cc0’s typescript-eslint version bumps in package.json #1490
  • Add a basic test of NPM package #1476
  • Make MessageFilter subscription filtering tree-shakable#1473
  • Make HTTP request implementations tree-shakable #1438
  • Make realtime transports tree-shakable #1432
  • Remove PresenceMessage-related static things in tree-shakable library #1429
  • Make realtime presence functionality tree-shakable #1428
  • Create tree-shakable MsgPack module #1425
  • Create tree-shakable Crypto module #1419
  • Add tree-shakable Base* and Rest exports #1417
  • refactor: convert web comet transports to typescript #1379
  • build: use esbuild for web bundles #1369
  • Update the tests to use the Promise-based API #1349
  • Make ErrorInfo.fromValues’s signature correspond to its expectations #1322
  • Fix TypeScript 4.9.5 upgrade mistakes #1267
  • Upgrade TypeScript to 4.9.5 #1258
  • Update docstrings for Rest.request version param #1255
  • Convert platform crypto.js files to TypeScript #1246
  • Upgrade webpack to version 5 #1201

Resolves #1604

@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 1, 2024 05:45 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/bundle-report March 1, 2024 05:46 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/typedoc March 1, 2024 05:46 Inactive
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the whole, I agree with the categorisation of PRs into non-user facing, breaking, etc.

I do think, if this is gonna be what ends up as the description in the github release we should be a bit more 'product marketing' about how we present the changes at first, and maybe even start off with a short paragraph rather than going straight into bullet points. It doesn't look too exciting if the first thing someone sees is that we've dropped support for platforms, whereas if we start by saying stuff like "We've added a new way to remove bloat from your ably-js client and we're adding first class support to promises" that sounds better IMO.

A couple of things that stood out to me below:

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 1, 2024 21:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/bundle-report March 1, 2024 21:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/typedoc March 1, 2024 21:01 Inactive
@VeskeR
Copy link
Contributor Author

VeskeR commented Mar 1, 2024

I do think, if this is gonna be what ends up as the description in the github release we should be a bit more 'product marketing' about how we present the changes at first, and maybe even start off with a short paragraph rather than going straight into bullet points. It doesn't look too exciting if the first thing someone sees is that we've dropped support for platforms, whereas if we start by saying stuff like "We've added a new way to remove bloat from your ably-js client and we're adding first class support to promises" that sounds better IMO.

Updated intro.

I placed the platform support deprecations first, thinking it might be useful to immediately see what would break if you switch to this new version.
Upon a second look, however, I do agree that it looks underwhelming, so it has been changed now.

@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 1, 2024 21:33 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/typedoc March 1, 2024 21:33 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/bundle-report March 1, 2024 21:33 Inactive
@VeskeR VeskeR requested a review from owenpearson March 1, 2024 21:34
@lawrence-forooghian
Copy link
Collaborator

I think this needs to be reviewed as a single thing alongside the migration guide, the writing of which is assigned to me. I’m going to branch from this and write the migration guide, then we can review the two together.

@lawrence-forooghian
Copy link
Collaborator

Started working on migration guide in #1670.

Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 11, 2024 17:08 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/bundle-report March 11, 2024 17:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/typedoc March 11, 2024 17:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 11, 2024 17:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/typedoc March 11, 2024 17:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/bundle-report March 11, 2024 17:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 11, 2024 18:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/bundle-report March 11, 2024 18:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/typedoc March 20, 2024 20:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 20, 2024 22:04 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 20, 2024 22:05 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/bundle-report March 20, 2024 22:06 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/typedoc March 20, 2024 22:06 Inactive
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 21, 2024 15:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/bundle-report March 21, 2024 15:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/typedoc March 21, 2024 15:18 Inactive
@VeskeR
Copy link
Contributor Author

VeskeR commented Mar 21, 2024

Updated for latest changes 2e12459...c02ec56:

no user-facing changes

@VeskeR VeskeR marked this pull request as ready for review March 21, 2024 16:21
@github-actions github-actions bot temporarily deployed to staging/pull/1656/features March 21, 2024 16:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/bundle-report March 21, 2024 16:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1656/typedoc March 21, 2024 16:28 Inactive
@VeskeR VeskeR changed the title [ECO-4122] Draft 2.0.0 changelog [ECO-4122] v2.0.0 changelog Mar 21, 2024
@VeskeR VeskeR merged commit 1a4dc28 into integration/v2 Mar 21, 2024
10 of 12 checks passed
@VeskeR VeskeR deleted the 1604/v2-changelog branch March 21, 2024 16:36
This was referenced Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants