-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-4122] v2.0.0 changelog #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the whole, I agree with the categorisation of PRs into non-user facing, breaking, etc.
I do think, if this is gonna be what ends up as the description in the github release we should be a bit more 'product marketing' about how we present the changes at first, and maybe even start off with a short paragraph rather than going straight into bullet points. It doesn't look too exciting if the first thing someone sees is that we've dropped support for platforms, whereas if we start by saying stuff like "We've added a new way to remove bloat from your ably-js client and we're adding first class support to promises" that sounds better IMO.
A couple of things that stood out to me below:
Updated intro. I placed the platform support deprecations first, thinking it might be useful to immediately see what would break if you switch to this new version. |
I think this needs to be reviewed as a single thing alongside the migration guide, the writing of which is assigned to me. I’m going to branch from this and write the migration guide, then we can review the two together. |
Started working on migration guide in #1670. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
dd8db94
to
35738de
Compare
e6d72a7
to
3409481
Compare
1425967
to
c4102a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Updated for latest changes 2e12459...c02ec56: no user-facing changes |
9b908a0
to
b2e6044
Compare
Based on changes between dc761e7...c02ec56
b2e6044
to
7e13b2f
Compare
Changelog is based on changes between e71ed5f...c02ec56 (latest
main
andintegration/v2
diff as of March 21).PRs that need to be added to the changelog when finished/reviewed and merged:
whenState
in line with spec #1640 - API changexhr_streaming
TransportusePresence
hook into different hooks for entering presence and subscribing to presence events #1621 - breaking API changeid
field in react-hooks forAblyProvider
and channel options #1637 - breaking API changeClientOptions.plugins
mechanism and use it for modular variant #1663 - breaking API changepublish
to theuseChannel
hook #1658 - new API featureChannelProvider
documentation #1654 -ChannelProvider
documentationskip
parameter to React docs #1675 - falls under refactoringPlease note that this is not an exhaustive list of tasks that need to be completed before the v2 release. This list contains only the user-facing PRs/tasks that must be added to the changelog.
Pull requests not included in this changelog (I considered them as Miscellaneous / Extras, non-user facing):
skip
parameter for hooks to React docs #1675Resolves #1604