-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build r-tiledbsoma with C++ 20 #231
base: main
Are you sure you want to change the base?
Conversation
For some reason the osx-64 build isn't using C++20. The errors are the same as in the nightly build (#230 (comment)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I guess this makes sense. The osx-64 build is the most complicated since it is the only one that uses the wrapper functions: tiledbsoma-feedstock/recipe/build-r-tiledbsoma.sh Lines 9 to 19 in fd059f0
These wrapper scripts were initially added to handle C++17 requirements (conda-forge/r-tiledb-feedstock@29cb681, conda-forge/r-tiledb-feedstock#27). Maybe C++20 has different requirements? |
Ah, looking earlier in the build log, I see we have a nice diagnostic signal. R explicitly tells us it is using C++17 on osx-64. * installing *source* package ‘tiledbsoma’ ...
** using staged installation
** updated src/Makevars for system library via pkg-config
** libs
using C++ compiler: ‘clang version 18.1.8’
using C++17
using SDK: ‘NA’‘NA’‘NA’‘’ Bizarrely though, the osx-arm64 build also reports |
Commit 3:
|
I think it is going to be tough to build r-tiledbsoma with C++20 without the upstream changes in single-cell-data/TileDB-SOMA#3331 that updated If we want to fix the nightly build, I think we'll need to 1) fix the build on the branch nightly-build, and then 2) modify |
@jdblischak I was confused single-cell-data/TileDB-SOMA#3331 is merged to Let me take a look at |
Good news! The TileDB-SOMA-R build in centralized-tiledb-nightlies is using C++20 and building without error. Thus if we can get the nightly feedstock build to also use C++20, it should just work. |
Awesome, thanks @jdblischak ! I'm still working on what I need to type to get us there. |
…nda-forge-pinning 2024.11.20.13.33.43
Context: single-cell-data/TileDB-SOMA#3154